vectordotdev
feat(new source): Initial `mqtt` source
Closes #584
I made this initial implementation farily simple, one important point is that I have not implemented acknowledgements.
Hi, is this PR still actively being worked on? Would love to see an MQTT sink shipped, happy to contribute to that effort
Sorry, I forgot about it. I believe the only major thing I left unresolved is deduplication between the sink and source but don't quote me on that.
Feel free to push it over the finish line. I can't promise I'd have time to get back to this in the coming weeks and definitely not in the coming days.
Looking forward to having this feature. :partying_face:
Is this ready for merge?
Hi @mladedav I see this is quite stale, is this PR still being worked on or should it be closed ?
I'm obviously biased but I think it would be a shame to close this.
IIRC the code works (unless there are conflicts now with the main branch) and the only thing I didn't get around to was code deduplication between the mqtt source and sink.
I'm obviously biased but I think it would be a shame to close this.
IIRC the code works (unless there are conflicts now with the main branch) and the only thing I didn't get around to was code deduplication between the mqtt source and sink.
Thanks @mladedav, are you motivated to take this over the finish line? I can help with fast reviews if so.
I will (1) review, (2) if it's not too much effort address nits. If it turns out this need a lot of dev work, I will leave it up to community to take it over the finish line.
@pront can this be expected to be merged anytime soon ?
The PR still needs some work. But if I recall correctly it's almost there.
Are we there yet ?
There hasn't been any activity on this PR for a while. If some community member wants to fork it or work on this directly, I am happy to review.