fix(elasticsearch sink): Readd error log for elasticsearch sink

[jszwedko]

trafficstars

Users were depending on this log to determine the number of failed events. Ideally these failed events could be routed from the sink and counted that way, but until then re-adding the log unblocks users from upgrading.

Fixes: #15886

Signed-off-by: Jesse Szwedko [email protected]

[datadog-vectordotdev[bot]]

Datadog Report

Branch report: jszwedko/readd-elasticsearch-log Commit report: fdef1c0 Test service: vector

:white_check_mark: 0 Failed, 2122 Passed, 0 Skipped, 1m 25.23s Wall Time

[amanmahajan26]

@jszwedko Do you have any update as to when this would get merged?

[jszwedko]

@jszwedko Do you have any update as to when this would get merged?

Apologies, there are some test failures I haven't been able to circle back to just yet. I'm hoping to before the next release.

[amanmahajan26]

No worries. Thanks for the update @jszwedko 👍🤞

[amanmahajan26]

@jszwedko I hope that we can still merge it in 0.37 release 🤞 Please keep me posted.

[amanmahajan26]

Hi @jszwedko, can you please update me about the status of this fix? It would be really great for us if this gets merged before the next release..

[datadog-vectordotdev[bot]]

Datadog Report

Branch report: jszwedko/readd-elasticsearch-log Commit report: 7157887 Test service: vector

:white_check_mark: 0 Failed, 23 Passed, 0 Skipped, 1m 11.21s Wall Time

[github-actions[bot]]

Regression Detector Results

Run ID: ed17c049-9855-46ba-8f39-e9dcbb92bb52 Baseline: d23730e3138c20fac276178357234135f1fc52bd Comparison: ebdc64dbfc0ac71a1ff73ab9080849eca718a442 Total CPUs: 7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+3.70	[+3.55, +3.85]
➖	syslog_splunk_hec_logs	ingress throughput	+3.46	[+3.36, +3.55]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+2.54	[+2.39, +2.69]
➖	file_to_blackhole	egress throughput	+1.92	[-0.60, +4.44]
➖	http_to_http_acks	ingress throughput	+1.72	[+0.39, +3.04]
➖	syslog_humio_logs	ingress throughput	+1.22	[+1.10, +1.34]
➖	otlp_grpc_to_blackhole	ingress throughput	+1.19	[+1.10, +1.27]
➖	syslog_log2metric_humio_metrics	ingress throughput	+1.13	[+1.02, +1.24]
➖	datadog_agent_remap_datadog_logs	ingress throughput	+1.05	[+0.95, +1.16]
➖	otlp_http_to_blackhole	ingress throughput	+0.81	[+0.65, +0.97]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.59	[+0.49, +0.69]
➖	http_to_s3	ingress throughput	+0.38	[+0.09, +0.66]
➖	http_to_http_noack	ingress throughput	+0.12	[+0.02, +0.23]
➖	http_to_http_json	ingress throughput	+0.03	[-0.04, +0.10]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.00	[-0.14, +0.14]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.15, +0.15]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	-0.03	[-0.18, +0.12]
➖	http_text_to_http_json	ingress throughput	-0.04	[-0.22, +0.14]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.05	[-0.16, +0.07]
➖	enterprise_http_to_http	ingress throughput	-0.17	[-0.25, -0.08]
➖	datadog_agent_remap_blackhole	ingress throughput	-0.20	[-0.35, -0.05]
➖	socket_to_socket_blackhole	ingress throughput	-0.27	[-0.33, -0.20]
➖	http_elasticsearch	ingress throughput	-0.31	[-0.37, -0.24]
➖	fluent_elasticsearch	ingress throughput	-0.80	[-1.27, -0.33]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	-1.27	[-1.37, -1.16]
➖	syslog_loki	ingress throughput	-1.46	[-1.57, -1.36]
➖	splunk_hec_route_s3	ingress throughput	-2.11	[-2.60, -1.63]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[jszwedko]

Hi @jszwedko, can you please update me about the status of this fix? It would be really great for us if this gets merged before the next release..

Thanks for the bump on this. It's finally been merged at long last. Thanks for you patience!