vector icon indicating copy to clipboard operation
vector copied to clipboard

enhancement(datadog_logs sink): default to zstd compression

Open dsmith3197 opened this issue 1 year ago • 9 comments
trafficstars

https://github.com/vectordotdev/vector/issues/18526

This needs to be tested.

dsmith3197 avatar Dec 22 '23 18:12 dsmith3197

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link: VRL Playground preview

github-actions[bot] avatar Dec 22 '23 18:12 github-actions[bot]

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link: Rust Doc preview

github-actions[bot] avatar Dec 22 '23 18:12 github-actions[bot]

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link: vector.dev preview

github-actions[bot] avatar Dec 22 '23 18:12 github-actions[bot]

/ci-run-regression

dsmith3197 avatar Dec 22 '23 18:12 dsmith3197

Datadog Report

Branch report: dougsmith/datadog-default-zstd Commit report: 426c604

:x: vector: 1 Failed (0 Known Flaky), 0 New Flaky, 2077 Passed, 0 Skipped, 9m 6.49s Wall Time

:x: Failed Tests (1)

  • sinks::datadog::traces::apm_stats::integration_tests::apm_stats_e2e_test_dd_agent_to_vector_correctness - vector - Details

    Expand for error
    est has failed
    

Regression Detector Results

Run ID: 9565fde1-a9b1-47c0-85cf-a5da2a04797a Baseline: af4de5eae6ad454fccd47fc933ac02bafa579446 Comparison: b0af10db473cf5ddd355f0834b651a6c864d695b Total CPUs: 7

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

Experiments with missing or malformed data

  • datadog_agent_remap_datadog_logs
  • datadog_agent_remap_datadog_logs_acks

Usually, this warning means that there is no usable optimization goal data for that experiment, which could be a result of misconfiguration.

No significant changes in experiment optimization goals

Confidence level: 90.00% Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
syslog_log2metric_splunk_hec_metrics ingress throughput +1.91 [+1.75, +2.06]
datadog_agent_remap_blackhole_acks ingress throughput +1.63 [+1.52, +1.74]
http_elasticsearch ingress throughput +1.14 [+1.06, +1.21]
syslog_humio_logs ingress throughput +1.13 [+1.02, +1.23]
datadog_agent_remap_blackhole ingress throughput +1.08 [+0.98, +1.18]
syslog_regex_logs2metric_ddmetrics ingress throughput +0.80 [+0.71, +0.88]
syslog_splunk_hec_logs ingress throughput +0.70 [+0.66, +0.75]
otlp_grpc_to_blackhole ingress throughput +0.40 [+0.30, +0.50]
splunk_hec_route_s3 ingress throughput +0.27 [-0.26, +0.79]
http_to_http_noack ingress throughput +0.12 [+0.02, +0.21]
http_to_http_json ingress throughput +0.04 [-0.03, +0.11]
splunk_hec_to_splunk_hec_logs_acks ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.14, +0.14]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.01 [-0.12, +0.11]
enterprise_http_to_http ingress throughput -0.12 [-0.20, -0.04]
http_to_s3 ingress throughput -0.20 [-0.48, +0.07]
http_text_to_http_json ingress throughput -0.23 [-0.35, -0.10]
socket_to_socket_blackhole ingress throughput -0.24 [-0.33, -0.15]
syslog_loki ingress throughput -0.24 [-0.30, -0.18]
http_to_http_acks ingress throughput -0.27 [-1.58, +1.04]
fluent_elasticsearch ingress throughput -0.45 [-0.92, +0.03]
file_to_blackhole egress throughput -0.79 [-3.36, +1.78]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput -0.81 [-0.93, -0.70]
otlp_http_to_blackhole ingress throughput -1.19 [-1.34, -1.04]
syslog_log2metric_humio_metrics ingress throughput -2.21 [-2.36, -2.05]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

github-actions[bot] avatar Dec 22 '23 19:12 github-actions[bot]