vector
vector copied to clipboard
vectordotdev
enhancement(kubernetes_logs source): add container_start_time to k8s_logs
This adds the container start time to the kubernetes_logs source. While container_id helps distinguish between different instances of the same container, it does not clarify the time-order of these container. Often, we want to be able to look at the logs
My understanding (not confirmed, but based on my understanding of kubernetes) is that this field may not be filled in before the container starts. This means some early log lines may have chance of missing this label. If this is actually the case, its still useful to use the existence of log lines with both the container_id and start_time label to associate container instances with their start time
Deploy Preview for vector-project canceled.
| Name | Link |
|---|---|
| Latest commit | 6df90ff1a8cf6360f716802b0974463dd7cc7dbc |
| Latest deploy log | https://app.netlify.com/sites/vector-project/deploys/65009e2850166200084b7014 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for vrl-playground ready!
| Name | Link |
|---|---|
| Latest commit | 6df90ff1a8cf6360f716802b0974463dd7cc7dbc |
| Latest deploy log | https://app.netlify.com/sites/vrl-playground/deploys/65009e28763a2f0008d6f8b5 |
| Deploy Preview | https://deploy-preview-18456--vrl-playground.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Thanks for making the changes @guswynn! In the future, if you would, avoiding force-pushing is greatly appreciated. Force pushing makes it really hard to review incremental changes.
Thanks for making the changes @guswynn! In the future, if you would, avoiding force-pushing is greatly appreciated. Force pushing makes it really hard to review incremental changes.
Hi @guswynn , it looks like there was another force push made. Would you mind describing or pointing out the change you made on september 7th? It's not clear to me what was done or if it is related to the CI failure I pointed out.
Hi @guswynn , it looks like there are merge conflicts in this PR. Would you mind fixing those, (not force pushing) and then I can re-review the changes, thanks 🙏
Thank you for your contribution to Vector! To keep the repository tidy and focused, we are closing this PR due to inactivity. We greatly appreciate the time and effort you've put into this PR.If you'd like to continue working on it, we encourage you to re-open the PR and we would be delighted to review it again. Before re-opening, please use git merge origin master to resolve any conflicts with origin/master.
