chore(observability): Don't include name field for SinkRequestBuildError

[spencergilbert]

• chore(observability): Don't include name field for SinkRequestBuildError
• chore: Fix typos and use NamedComponent for http_scrape

The name field duplicates the info included at the beginning of the log, removing it saves us some work.

2022-09-21T20:11:11.005652Z ERROR sink{component_kind="sink" component_id=sink0 component_type=aws_s3 component_name=sink0}: vector::internal_events::common: Failed to build request for <NAME> error=<ERROR> error_type="encoder_failed" stage="processing" internal_log_rate_limit=true

[netlify[bot]]

✅ Deploy Preview for vector-project canceled.

Name	Link
🔨 Latest commit	404edb601bb2cc3c444d4b532f61ce0f22a2d46c
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/632c633f2d0eb1000cba0691

[github-actions[bot]]

Soak Test Results

Baseline: d8ca608861ee14e572a3a41cc49728678b9b7c91 Comparison: 404edb601bb2cc3c444d4b532f61ce0f22a2d46c Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline outlier %	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison outlier %	comparison CoV	erratic	declared erratic
socket_to_socket_blackhole	811.09KiB	3.55	100.00%	22.28MiB	570.93KiB	11.65KiB	0	0.0250149	23.08MiB	485.28KiB	9.91KiB	0	0.0205324	False	False
http_text_to_http_json	1.0MiB	2.6	100.00%	38.57MiB	1.22MiB	25.59KiB	0	0.0317334	39.57MiB	1.04MiB	21.83KiB	0	0.0263862	False	False
syslog_regex_logs2metric_ddmetrics	192.34KiB	1.53	100.00%	12.26MiB	734.36KiB	14.96KiB	0	0.0584912	12.45MiB	657.34KiB	13.4KiB	0	0.0515662	False	False
datadog_agent_remap_blackhole_acks	832.72KiB	1.33	100.00%	61.21MiB	4.1MiB	85.5KiB	0	0.0670476	62.02MiB	1.99MiB	41.65KiB	0	0.0320385	False	False
datadog_agent_remap_datadog_logs	644.93KiB	1.02	100.00%	61.66MiB	639.7KiB	13.09KiB	0	0.01013	62.29MiB	4.33MiB	90.18KiB	0	0.069527	False	False
datadog_agent_remap_datadog_logs_acks	589.07KiB	0.93	100.00%	62.11MiB	3.32MiB	69.29KiB	0	0.0533815	62.69MiB	4.26MiB	88.81KiB	0	0.0680206	False	False
http_pipelines_blackhole_acks	10.88KiB	0.92	99.97%	1.16MiB	107.07KiB	2.18KiB	0	0.0902998	1.17MiB	99.17KiB	2.02KiB	0	0.0828794	False	False
syslog_loki	122.07KiB	0.84	100.00%	14.27MiB	538.46KiB	11.02KiB	0	0.0368429	14.39MiB	898.06KiB	18.26KiB	0	0.0609388	False	False
http_to_http_acks	96.25KiB	0.55	32.00%	17.11MiB	7.9MiB	165.24KiB	0	0.461611	17.21MiB	7.9MiB	164.72KiB	0	0.458871	True	True
syslog_splunk_hec_logs	81.6KiB	0.49	99.99%	16.39MiB	762.48KiB	15.51KiB	0	0.0454256	16.47MiB	651.82KiB	13.29KiB	0	0.0386452	False	False
splunk_hec_route_s3	65.88KiB	0.34	68.93%	18.83MiB	2.22MiB	46.3KiB	0	0.118129	18.89MiB	2.18MiB	45.59KiB	0	0.115311	False	False
datadog_agent_remap_blackhole	163.49KiB	0.27	83.45%	58.45MiB	4.2MiB	87.61KiB	0	0.0718408	58.61MiB	3.78MiB	78.87KiB	0	0.0644988	False	False
splunk_hec_to_splunk_hec_logs_noack	11.26KiB	0.05	68.80%	23.83MiB	431.35KiB	8.8KiB	0	0.0176757	23.84MiB	334.2KiB	6.82KiB	0	0.0136883	False	False
splunk_hec_to_splunk_hec_logs_acks	9.6KiB	0.04	31.10%	23.75MiB	850.23KiB	17.29KiB	0	0.0349503	23.76MiB	817.41KiB	16.63KiB	0	0.0335878	False	False
enterprise_http_to_http	-1.2KiB	-0	13.11%	23.85MiB	250.12KiB	5.11KiB	0	0.0102404	23.85MiB	255.14KiB	5.22KiB	0	0.0104465	False	False
syslog_log2metric_humio_metrics	-1.02KiB	-0.01	7.50%	12.28MiB	205.0KiB	4.18KiB	0	0.0162968	12.28MiB	490.54KiB	9.99KiB	0	0.0389993	False	False
file_to_blackhole	-60.78KiB	-0.06	40.57%	95.33MiB	3.6MiB	74.62KiB	0	0.0377657	95.27MiB	4.15MiB	86.3KiB	0	0.0435461	False	False
splunk_hec_indexer_ack_blackhole	-20.59KiB	-0.08	62.65%	23.76MiB	764.02KiB	15.55KiB	0	0.0313892	23.74MiB	842.55KiB	17.13KiB	0	0.0346447	False	False
syslog_humio_logs	-18.33KiB	-0.11	99.02%	16.27MiB	298.06KiB	6.08KiB	0	0.0178845	16.25MiB	178.51KiB	3.66KiB	0	0.0107231	False	False
http_to_http_json	-54.34KiB	-0.22	99.99%	23.85MiB	326.17KiB	6.66KiB	0	0.0133541	23.79MiB	613.04KiB	12.5KiB	0	0.025155	False	False
fluent_elasticsearch	-179.31KiB	-0.22	100.00%	79.47MiB	53.09KiB	1.07KiB	0	0.000652194	79.3MiB	1.67MiB	34.41KiB	0	0.021073	False	False
syslog_log2metric_splunk_hec_metrics	-41.08KiB	-0.23	96.15%	17.78MiB	580.82KiB	11.84KiB	0	0.0318883	17.74MiB	782.31KiB	15.93KiB	0	0.0430473	False	False
http_to_http_noack	-66.57KiB	-0.27	99.56%	23.83MiB	503.1KiB	10.28KiB	0	0.0206153	23.76MiB	1.01MiB	20.98KiB	0	0.0423161	False	False
http_pipelines_blackhole	-7.66KiB	-0.44	99.51%	1.71MiB	9.59KiB	200.47B	0	0.0054785	1.7MiB	133.04KiB	2.71KiB	0	0.0763589	False	False
http_pipelines_no_grok_blackhole	-77.26KiB	-0.7	99.96%	10.84MiB	35.79KiB	748.34B	0	0.00322371	10.77MiB	1.04MiB	21.67KiB	0	0.0966413	False	False