enhancement(aws_s3 sink): File cleanup and use SinkRequestBuildError

[spencergilbert]

Closes #14205

• chore(aws_s3 sink): Cleanup files and rename tests module
• chore(aws_s3 sink): Cleanup s3_common files
• chore(aws_s3 sink): Comment and use SinkRequestBuildError in s3_common

[netlify[bot]]

✅ Deploy Preview for vector-project canceled.

Name	Link
🔨 Latest commit	35d0f2d7f97e610a694b64f12cc91ef2df79084e
🔍 Latest deploy log	https://app.netlify.com/sites/vector-project/deploys/632c880c0eb77a00087a7035

[github-actions[bot]]

Soak Test Results

Baseline: 9cf1ea9b08ed745e3872c1cc81757f6078c82419 Comparison: 5feadfad4146811a9efff9d07c083cff7dabcf36 Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

Fine details of change detection per experiment.

experiment	Δ mean	Δ mean %	confidence	baseline mean	baseline stdev	baseline stderr	baseline outlier %	baseline CoV	comparison mean	comparison stdev	comparison stderr	comparison outlier %	comparison CoV	erratic	declared erratic
http_pipelines_blackhole_acks	3.99KiB	0.32	84.76%	1.23MiB	109.08KiB	2.22KiB	0	0.08653	1.23MiB	82.78KiB	1.69KiB	0	0.0654646	False	False
http_to_http_acks	28.57KiB	0.16	9.61%	17.24MiB	8.01MiB	167.37KiB	0	0.464185	17.27MiB	8.02MiB	167.36KiB	0	0.46438	True	True
socket_to_socket_blackhole	34.35KiB	0.15	99.94%	22.84MiB	309.93KiB	6.33KiB	0	0.0132511	22.87MiB	379.22KiB	7.74KiB	0	0.0161896	False	False
splunk_hec_to_splunk_hec_logs_noack	16.0KiB	0.07	83.74%	23.82MiB	454.15KiB	9.27KiB	0	0.018612	23.84MiB	329.54KiB	6.73KiB	0	0.0134964	False	False
syslog_loki	2.3KiB	0.02	11.58%	14.29MiB	275.11KiB	5.64KiB	0	0.0187904	14.3MiB	724.13KiB	14.72KiB	0	0.0494515	False	False
enterprise_http_to_http	-994.38B	-0	10.61%	23.85MiB	250.1KiB	5.11KiB	0	0.0102404	23.85MiB	253.89KiB	5.19KiB	0	0.0103958	False	False
splunk_hec_indexer_ack_blackhole	226.29B	0	0.69%	23.75MiB	886.92KiB	18.04KiB	0	0.0364623	23.75MiB	892.78KiB	18.16KiB	0	0.0367029	False	False
splunk_hec_to_splunk_hec_logs_acks	-4.07KiB	-0.02	13.61%	23.76MiB	818.99KiB	16.67KiB	0	0.0336525	23.76MiB	832.25KiB	16.93KiB	0	0.0342031	False	False
datadog_agent_remap_blackhole	-45.18KiB	-0.07	32.88%	59.51MiB	3.89MiB	81.08KiB	0	0.0653195	59.46MiB	3.3MiB	68.91KiB	0	0.0555475	False	False
file_to_blackhole	-84.49KiB	-0.09	56.54%	95.34MiB	3.42MiB	71.0KiB	0	0.0359154	95.25MiB	3.93MiB	81.57KiB	0	0.0412058	False	False
syslog_regex_logs2metric_ddmetrics	-15.99KiB	-0.12	69.91%	12.6MiB	541.9KiB	11.05KiB	0	0.0420035	12.58MiB	530.08KiB	10.8KiB	0	0.0411386	False	False
http_to_http_json	-34.97KiB	-0.14	99.34%	23.84MiB	347.05KiB	7.08KiB	0	0.0142104	23.81MiB	525.55KiB	10.73KiB	0	0.0215502	False	False
datadog_agent_remap_blackhole_acks	-94.5KiB	-0.16	46.83%	58.76MiB	5.48MiB	114.07KiB	0	0.0931663	58.66MiB	4.74MiB	99.06KiB	0	0.0807505	False	False
fluent_elasticsearch	-151.11KiB	-0.19	100.00%	79.47MiB	52.04KiB	1.05KiB	0	0.000639391	79.33MiB	1.62MiB	33.39KiB	0	0.020457	False	False
http_to_http_noack	-119.69KiB	-0.49	100.00%	23.85MiB	251.42KiB	5.14KiB	0	0.0102944	23.73MiB	1.17MiB	24.35KiB	0	0.0492232	False	False
syslog_log2metric_humio_metrics	-93.68KiB	-0.72	100.00%	12.77MiB	397.55KiB	8.12KiB	0	0.0304026	12.68MiB	595.65KiB	12.13KiB	0	0.0458814	False	False
datadog_agent_remap_datadog_logs_acks	-567.41KiB	-0.92	100.00%	60.13MiB	3.58MiB	74.89KiB	0	0.0595773	59.57MiB	4.64MiB	96.56KiB	0	0.0778509	False	False
syslog_splunk_hec_logs	-187.13KiB	-1.12	100.00%	16.26MiB	783.25KiB	15.93KiB	0	0.0470282	16.08MiB	640.49KiB	13.07KiB	0	0.038894	False	False
splunk_hec_route_s3	-223.23KiB	-1.17	99.92%	18.58MiB	2.28MiB	47.59KiB	0	0.122951	18.36MiB	2.25MiB	46.96KiB	0	0.122476	False	False
http_text_to_http_json	-489.07KiB	-1.24	100.00%	38.49MiB	1.3MiB	27.17KiB	0	0.0337611	38.01MiB	1.22MiB	25.47KiB	0	0.0320471	False	False
syslog_humio_logs	-210.2KiB	-1.24	100.00%	16.56MiB	312.94KiB	6.39KiB	0	0.0184494	16.36MiB	314.73KiB	6.45KiB	0	0.018788	False	False
http_pipelines_no_grok_blackhole	-142.19KiB	-1.29	100.00%	10.75MiB	80.41KiB	1.64KiB	0	0.00730657	10.61MiB	1.08MiB	22.52KiB	0	0.101965	False	False
datadog_agent_remap_datadog_logs	-801.32KiB	-1.29	100.00%	60.6MiB	1.61MiB	33.81KiB	0	0.0266204	59.82MiB	4.04MiB	84.15KiB	0	0.0675119	False	False
http_pipelines_blackhole	-31.05KiB	-1.87	100.00%	1.62MiB	26.27KiB	549.98B	0	0.0158305	1.59MiB	121.02KiB	2.47KiB	0	0.0743262	False	False
syslog_log2metric_splunk_hec_metrics	-360.18KiB	-1.97	100.00%	17.88MiB	777.68KiB	15.84KiB	0	0.0424563	17.53MiB	954.34KiB	19.42KiB	0	0.0531463	False	False