vector icon indicating copy to clipboard operation
vector copied to clipboard

enhancement(geoip enrichment): Add support for Connection-Type databases

Open w4 opened this issue 3 years ago • 5 comments
trafficstars

Closes #13702

w4 avatar Jul 25 '22 21:07 w4

CLA assistant check
All committers have signed the CLA.

bits-bot avatar Jul 25 '22 21:07 bits-bot

Deploy Preview for vector-project canceled.

Name Link
Latest commit 373f144536d4eaac30a09a4ac3d53918ea4c7996
Latest deploy log https://app.netlify.com/sites/vector-project/deploys/62f6c01369b3430008f90f2d

netlify[bot] avatar Jul 25 '22 21:07 netlify[bot]

Hey @w4 ! Apologies for not getting to this sooner. This geoip transform is actually deprecated now that we've we added support for enriching geoip data via enrichment tables (see: https://github.com/vectordotdev/vector/pull/13338). Would you mind moving these changes over there?

jszwedko avatar Aug 05 '22 18:08 jszwedko

Ah interesting, will do thanks

w4 avatar Aug 06 '22 13:08 w4

This is updated now, thanks @jszwedko

w4 avatar Aug 07 '22 10:08 w4

@w4 I wasn't able to push to this PR branch for some reason. Would you mind applying the following diff:

0f3b36b3a - Document support for Connection-Type databases (5 minutes ago) <Jesse Szwedko>
diff --git a/website/cue/reference/remap/functions.cue b/website/cue/reference/remap/functions.cue
index d491c9873..f8fc7df8b 100644
--- a/website/cue/reference/remap/functions.cue
+++ b/website/cue/reference/remap/functions.cue
@@ -82,26 +82,27 @@ remap: {
 		and without a value, `null` will be used. This table can return following fields:
 
 		* ISP databases:
-
 			* `autonomous_system_number`
 			* `autonomous_system_organization`
 			* `isp`
 			* `organization`
 
 		* City databases:
-
 			* `city_name`
 			* `continent_code`
 			* `country_code`
 			* `country_name`
 			* `region_code`
 			* `region_name`
-			* `metro_code`		
+			* `metro_code`
 			* `latitude`
-			* `longitude`		
+			* `longitude`
 			* `postal_code`
 			* `timezone`
 
+		* Connection-Type databases:
+			* `connection_type`
+
 		To use this function, you need to update your Vector configuration to
 		include an
 		[`enrichment_tables`](\(urls.vector_configuration_global)/#enrichment_tables)

jszwedko avatar Aug 12 '22 18:08 jszwedko

Not a problem, that's all done - thanks @jszwedko

w4 avatar Aug 12 '22 19:08 w4

Great, thanks! I marked this to merge once CI passes.

jszwedko avatar Aug 12 '22 20:08 jszwedko

Soak Test Results

Baseline: e1268b1ad376669dc8069d0bf59d34dedc415b2e Comparison: df3dc2eabce6ded18518eb851eff5367038d5041 Total Vector CPUs: 4

Explanation

A soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed.

Changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%:

experiment Δ mean Δ mean % confidence
socket_to_socket_blackhole -9.29MiB -41.46 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
syslog_humio_logs 644.83KiB 3.83 100.00% 16.44MiB 546.68KiB 11.16KiB 0 0.0324749 17.07MiB 154.21KiB 3.16KiB 0 0.00882254 False False
syslog_log2metric_splunk_hec_metrics 598.87KiB 3.33 100.00% 17.56MiB 557.67KiB 11.37KiB 0 0.0310023 18.15MiB 867.65KiB 17.66KiB 0 0.0466799 False False
syslog_splunk_hec_logs 533.25KiB 3.21 100.00% 16.2MiB 715.96KiB 14.59KiB 0 0.0431527 16.72MiB 686.22KiB 13.99KiB 0 0.0400719 False False
syslog_regex_logs2metric_ddmetrics 351.27KiB 2.75 100.00% 12.49MiB 586.03KiB 11.94KiB 0 0.0458116 12.83MiB 656.73KiB 13.37KiB 0 0.0499661 False False
http_to_http_acks 426.61KiB 2.38 91.99% 17.48MiB 7.8MiB 163.06KiB 0 0.446141 17.9MiB 8.68MiB 181.16KiB 0 0.485043 True True
syslog_log2metric_humio_metrics 203.16KiB 1.53 100.00% 12.98MiB 317.69KiB 6.49KiB 0 0.0238919 13.18MiB 447.54KiB 9.12KiB 0 0.0331508 False False
splunk_hec_route_s3 177.97KiB 0.93 99.36% 18.71MiB 2.29MiB 47.66KiB 0 0.12229 18.88MiB 2.13MiB 44.57KiB 0 0.112806 False False
http_pipelines_no_grok_blackhole 52.35KiB 0.48 94.73% 10.67MiB 616.57KiB 12.58KiB 0 0.0563942 10.73MiB 1.15MiB 23.91KiB 0 0.106993 False False
datadog_agent_remap_blackhole 270.02KiB 0.44 87.41% 59.69MiB 6.43MiB 133.96KiB 0 0.107755 59.95MiB 5.5MiB 114.75KiB 0 0.0917311 False False
splunk_hec_to_splunk_hec_logs_noack 15.81KiB 0.06 81.74% 23.82MiB 476.09KiB 9.71KiB 0 0.0195129 23.84MiB 333.32KiB 6.81KiB 0 0.0136525 False False
splunk_hec_to_splunk_hec_logs_acks 122.65B 0 0.38% 23.75MiB 876.12KiB 17.82KiB 0 0.0360244 23.75MiB 877.9KiB 17.85KiB 0 0.0360977 False False
enterprise_http_to_http -3.92KiB -0.02 40.14% 23.85MiB 259.29KiB 5.29KiB 0 0.0106156 23.84MiB 255.5KiB 5.23KiB 0 0.0104619 False False
splunk_hec_indexer_ack_blackhole -4.53KiB -0.02 14.53% 23.76MiB 851.0KiB 17.32KiB 0 0.0349713 23.75MiB 866.44KiB 17.63KiB 0 0.0356124 False False
file_to_blackhole -31.7KiB -0.03 23.16% 95.34MiB 3.67MiB 76.17KiB 0 0.0385381 95.31MiB 3.66MiB 76.11KiB 0 0.0383659 False False
http_to_http_json -22.24KiB -0.09 92.31% 23.84MiB 373.06KiB 7.62KiB 0 0.0152792 23.82MiB 489.2KiB 10.0KiB 0 0.0200541 False False
fluent_elasticsearch -291.29KiB -0.36 100.00% 79.47MiB 52.25KiB 1.06KiB 0 0.000641958 79.19MiB 3.08MiB 63.24KiB 0 0.0388459 False False
http_to_http_noack -115.54KiB -0.47 100.00% 23.84MiB 414.56KiB 8.48KiB 0 0.0169813 23.72MiB 1.18MiB 24.68KiB 0 0.0499172 False False
datadog_agent_remap_datadog_logs_acks -864.05KiB -1.37 100.00% 61.43MiB 4.33MiB 90.34KiB 0 0.070493 60.58MiB 4.63MiB 96.46KiB 0 0.076476 False False
syslog_loki -267.99KiB -1.8 100.00% 14.55MiB 368.9KiB 7.55KiB 0 0.0247524 14.29MiB 716.04KiB 14.56KiB 0 0.0489242 False False
http_text_to_http_json -847.31KiB -2.16 100.00% 38.27MiB 1.23MiB 25.69KiB 0 0.032117 37.44MiB 1.09MiB 22.85KiB 0 0.0291872 False False
datadog_agent_remap_blackhole_acks -1.37MiB -2.21 100.00% 61.84MiB 5.52MiB 114.86KiB 0 0.0891793 60.47MiB 5.01MiB 104.82KiB 0 0.0828816 False False
http_pipelines_blackhole_acks -42.07KiB -3.51 100.00% 1.17MiB 98.58KiB 2.01KiB 0 0.0821765 1.13MiB 90.81KiB 1.85KiB 0 0.0784489 False False
datadog_agent_remap_datadog_logs -2.38MiB -3.91 100.00% 61.0MiB 3.31MiB 69.46KiB 0 0.0543099 58.61MiB 4.97MiB 103.45KiB 0 0.0847403 False False
http_pipelines_blackhole -79.68KiB -4.81 100.00% 1.62MiB 62.17KiB 1.27KiB 0 0.0375454 1.54MiB 117.73KiB 2.4KiB 0 0.0746903 False False
socket_to_socket_blackhole -9.29MiB -41.46 100.00% 22.41MiB 575.47KiB 11.75KiB 0 0.0250701 13.12MiB 312.08KiB 6.37KiB 0 0.0232232 False False

github-actions[bot] avatar Aug 12 '22 20:08 github-actions[bot]

Merging since CI failure was from master.

jszwedko avatar Aug 15 '22 13:08 jszwedko