gitdocs icon indicating copy to clipboard operation
gitdocs copied to clipboard

[Feature] buildForRoot flag, determines if the build should be relative or absolute

Open blakewilson opened this issue 6 years ago • 3 comments

Hi team, I've built a feature that would generate the build with relative links to the web server root. This is helpful if you want to have multiple instances of gitdocs in different sub directories:

  • https://example.com/docs/docs-site-1
  • https://example.com/docs/docs-site-2

I think this is a huge advantage and would work perfectly with the repo.

This feature works by first setting the buildForRoot config flag to false (set to true by default, which is standard behavior), while also setting the baseURL.

This PR addresses #171 and #165

Any feedback is welcome!

Blake

blakewilson avatar Aug 14 '19 00:08 blakewilson

Nice! Looked through the code and don't have any major complaints, looks like we'll need to fix the tests but otherwise I'm 👍

zsherman avatar Aug 14 '19 01:08 zsherman

Awesome! If there is anything you would like done another way I could of course modify the code. Additionally, I can write some docs on the new feature in a couple of hours when I get back home 👍

blakewilson avatar Aug 14 '19 01:08 blakewilson

Any progress on this PR? I am also facing the same issue for my Github pages.

Gokuldroid avatar May 01 '20 18:05 Gokuldroid