thor icon indicating copy to clipboard operation
thor copied to clipboard

Add support for latest

Open MakisChristou opened this issue 1 year ago • 2 comments

Description

Added support for latest without removing support for best.

Fixes #91

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

make test-coverage

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] New and existing E2E tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have not added any vulnerable dependencies to my code

MakisChristou avatar Jan 31 '24 12:01 MakisChristou

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (39ecf84) 57.40% compared to head (2d262cf) 51.99%. Report is 2 commits behind head on master.

:exclamation: Current head 2d262cf differs from pull request most recent head 2192ee9. Consider uploading reports for the commit 2192ee9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #665      +/-   ##
==========================================
- Coverage   57.40%   51.99%   -5.42%     
==========================================
  Files         179      156      -23     
  Lines       20678    17239    -3439     
==========================================
- Hits        11870     8963    -2907     
+ Misses       7922     7453     -469     
+ Partials      886      823      -63     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 31 '24 12:01 codecov-commenter

should we also need "latest" for accounts, please update "handleRevision" in accounts.go thanks

claytonneal avatar Feb 01 '24 09:02 claytonneal

Close it due to not being interested.

libotony avatar Apr 25 '24 08:04 libotony