thor
thor copied to clipboard
Add muxdb test to increase coverage
Description
I had to add new functions in node.go
to get the desired coverage. @libotony Please let me know what you think.
Fixes # (issue)
Type of change
Testing
How Has This Been Tested?
make test-coverage
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [x] New and existing E2E tests pass locally with my changes
- [x] Any dependent changes have been merged and published in downstream modules
- [x] I have not added any vulnerable dependencies to my code
It'll be better to delay this PR, since the maindb-v4 brings a lot of changes to package trie
and muxdb
.
@qianbin we can mark the trie
and muxdb
code coverage tasks as blocked until the maindb-v4
is merged into main
.
@qianbin we can mark the
trie
andmuxdb
code coverage tasks as blocked until themaindb-v4
is merged intomain
.
OK, thanks.
This pull request has been marked as stale due to inactivity. It will be closed if no further activity occurs. Thank you for your contributions.
Codecov Report
Attention: Patch coverage is 0%
with 15 lines
in your changes are missing coverage. Please review.
Project coverage is 55.52%. Comparing base (
dbe9923
) to head (9720fd9
). Report is 18 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
trie/node.go | 0.00% | 15 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 55.09% 55.52% +0.42%
==========================================
Files 179 179
Lines 20665 20680 +15
==========================================
+ Hits 11386 11483 +97
+ Misses 8442 8353 -89
- Partials 837 844 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@nwbrettski @libotony @qianbin
I understand that there will be changes in maindb-v4
that will change this PR. It does seem that this PRs goal (outside adding tests) is to improve code coverage, which it does.
Since the maindb-v4 is still under dev/test we should make a call to either merge this PR or remove it to avoid have stale PR's.
Decision made to close this PR while the work continues on the maindb-v4.