npci icon indicating copy to clipboard operation
npci copied to clipboard

Hope to Get Some Clarification about the Setting A

Open uqhwen2 opened this issue 3 years ago • 0 comments

Hi Vdorie,

I saw your confusion that everyone is using your implementation for IHDP dataset simulation. Haha, I thought it is because of this highly cited NeurIPS 2016 paper, the auther claimed that they used your npci repo. I know your repo also due to this paper.

Get back to my confusion, I found out that you responded to the simulation setting things "is the setting A, B and C same to Jennifer Hill's setting A, B and C" with Yes answer. But what I found from your R code (from data.R file under ihdp_sim folder) is like:

Screen Shot 2022-05-17 at 6 46 20 pm

From my understanding, if we set setting=="A", for the highlighted area, your algorithm will go to the else part isn't it? But, the response surface A in Jennifer's paper is stated to be linear, and I also refer to her code as follows:

Screen Shot 2022-05-17 at 6 47 01 pm

The response surface B, which is non-linear, is similar to your code under the else condition. And if we set setting=="B", it will go through the linear response function under the if condition, which supposed to be non-linear in Jennifer's paper.

Thus, I just wanna confirm that, do we mess up the setting A and B here? Or if I miss something?

Thanks for any reply in advance!

Regards, Hechuan

uqhwen2 avatar May 17 '22 09:05 uqhwen2