npci icon indicating copy to clipboard operation
npci copied to clipboard

Does the setting=A refer to the setting A used by Jennifer Hill?

Open MaximilianFranz opened this issue 5 years ago • 3 comments

Hey there,

first off, thanks for implementing this package that has found so wide usage for evaluations. I was wondering whether the IHDP setting A in your code refers to the setting A proposed by Hill in her paper?

I find it hard to get a clear overview over all the different datasets based on IHDP used for comparison of causal effect estimators. This would make things a bit clearer.

Thanks!

MaximilianFranz avatar Aug 14 '19 10:08 MaximilianFranz

She describes her response surfaces in section 4.1

MaximilianFranz avatar Aug 14 '19 10:08 MaximilianFranz

Sorry, but I haven't even looked at this in a few years so I can't offer much help. I should really take it down, but I'm glad it's somewhat of use. But to the point, the settings here do correspond to the settings in Jennifer's paper. The only complication is that R changed how the sample function works, so you'll need to use RNGkind to set sample.kind to Rounding if you want to get identical results.

vdorie avatar Aug 16 '19 19:08 vdorie

Awesome, thanks for getting back to me so quickly! That's interesting. I'll look at this in more detail, as there seems to be a problem of reproducing results throughout different evaluations, which makes benchmarking causal estimators really hard.

MaximilianFranz avatar Aug 16 '19 21:08 MaximilianFranz