keep modified files out of source control

[lalanza808]

Great project! I got around to running it and had the following feedback. Should help reduce friction as you release updates so that people don't have to shuffle around files tracked by git, stash changes, pull, modify again, etc. If I have local changes to my .env or docker-compose.yml then it's tougher for me to get your cool new updates!

Also, added some light instructions to the README to help newbies with the install/run instructions since it might not be clear to them how to do all this fancy docker stuff.

ALSO - added one more config option to manually specify the monerod storage location rather than keep it hardcoded. I had a folder where my lmdb lived already so I'd like to just point it there to resume syncing. MONEROD_DATA_DIR

[vdo]

Thank you for the contribution!

Yes, makes sense to move those files out of source control. However:

• This change would break the one liner script installation as shown in xmr.sh website, so I think we should automate the creation of .env and docker-compose.yml in the install script.
• It would be better to do the PR to development branch, since I only use main when tagging for release.

[lalanza808]

Ah, I didn’t check that script! I just cloned and started farting around.

I will review it and make adjustments as well as switch the target branch. Standby….

On Tue, Sep 20, 2022 at 4:11 AM, vdo @.***> wrote:

Thank you for the contribution!

Yes, makes sense to move those files out of source control. However:

• This change would break the one liner script installation as shown in xmr.sh website, so I think we should automate the creation of .env and docker-compose.yml in the install script.
• It would be better to do the PR to development branch, since I only use main when tagging for release.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>