mtapi icon indicating copy to clipboard operation
mtapi copied to clipboard

Update MtApi.mq4

Open eabase opened this issue 3 years ago • 5 comments

Fixed formatting, encoding and trading bug

  • Fixed preventive use of trading password (bug #223)
  • Converted file from weird UTF-16LE to UTF-8
  • Removed blank trailing spaces
  • Removed tabs and converted mixed 3-tab indentation to 4-spaces
  • Simplified and reduced the Case statements
  • Changed old-school "fun() \n {" to "fun() {" formatting, saving 1500 lines.
  • Bumped version to 1.15

eabase avatar Nov 29 '20 19:11 eabase

@eabase please make PR into dev branch. I will merge it into master from dev.

vdemydiuk avatar Nov 30 '20 09:11 vdemydiuk

@vdemydiuk If you want to compare this to your version, you need to change the character encoding of your version. It seem that GitHub thinks its binary... use:

iconv.exe -f UTF-16 -t "ASCII" MtApi.mq4 >MtApi.cpp

Or to UTF-8. Then:
mv MtApi.cpp MtApi.mq4.

eabase avatar Dec 01 '20 15:12 eabase

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

BryanStackpole avatar Jan 22 '21 06:01 BryanStackpole

@BryanStackpole

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

Nobody can help you if you don't file a proper bug report of what you did, and what the output is. ...and this are comments for a pull request, not the issue section.

eabase avatar Jan 31 '21 15:01 eabase

@BryanStackpole

Hi, so when I try compile this file I get 124 errors? is there an error free version? May need to make custom commands.

Nobody can help you if you don't file a proper bug report of what you did, and what the output is. ...and this are comments for a pull request, not the issue section.

Yeah sry about that. I think the answer is in the readme.

BryanStackpole avatar Feb 01 '21 02:02 BryanStackpole