vald icon indicating copy to clipboard operation
vald copied to clipboard

Introduce opentelemetry

Open hlts2 opened this issue 2 years ago • 4 comments

Description:

WHAT

I introduced opentelemetry and deleted opencensus package.

WHY

we need to introduced opentelemetry for observability.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • [ ] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have checked open Pull Requests for the similar feature or fixes?
  • [ ] I have added tests and benchmarks to cover my changes.
  • [ ] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

hlts2 avatar Aug 22 '22 04:08 hlts2

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase main
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Aug 22 '22 04:08 vdaas-ci

Codecov Report

Base: 50.23% // Head: 30.32% // Decreases project coverage by -19.91% :warning:

Coverage data is based on head (416dec0) compared to base (97eed29). Patch coverage: 55.37% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1778       +/-   ##
===========================================
- Coverage   50.23%   30.32%   -19.92%     
===========================================
  Files         231      370      +139     
  Lines       13464    33689    +20225     
===========================================
+ Hits         6764    10216     +3452     
- Misses       6499    23054    +16555     
- Partials      201      419      +218     
Impacted Files Coverage Δ
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go 0.00% <ø> (ø)
hack/license/gen/main.go 0.00% <0.00%> (ø)
... and 244 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 22 '22 04:08 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 416dec0
Status: ✅  Deploy successful!
Preview URL: https://55078826.vald.pages.dev
Branch Preview URL: https://feature-observability-add-ob.vald.pages.dev

View logs

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci avatar Sep 02 '22 11:09 vdaas-ci