vald icon indicating copy to clipboard operation
vald copied to clipboard

[WIP] Feature Continuous Benchmark Tool

Open vankichi opened this issue 2 years ago • 4 comments

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • [ ] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have checked open Pull Requests for the similar feature or fixes?
  • [ ] I have added tests and benchmarks to cover my changes.
  • [ ] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

vankichi avatar Aug 17 '22 02:08 vankichi

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci avatar Aug 17 '22 02:08 vdaas-ci

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase main
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Aug 17 '22 02:08 vdaas-ci

Codecov Report

Base: 30.01% // Head: 29.97% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (7a1d4c0) compared to base (fd86b5c). Patch coverage: 18.60% of modified lines in pull request are covered.

:exclamation: Current head 7a1d4c0 differs from pull request most recent head d3cb49e. Consider uploading reports for the commit d3cb49e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1776      +/-   ##
==========================================
- Coverage   30.01%   29.97%   -0.05%     
==========================================
  Files         365      367       +2     
  Lines       33704    33747      +43     
==========================================
- Hits        10116    10114       -2     
- Misses      23180    23224      +44     
- Partials      408      409       +1     
Impacted Files Coverage Δ
internal/config/benchmark.go 0.00% <0.00%> (ø)
internal/config/server.go 96.22% <ø> (ø)
pkg/tools/benchmark/job/config/config.go 16.66% <16.66%> (ø)
internal/errors/http.go 100.00% <100.00%> (ø)
internal/net/http/middleware/timeout.go 91.11% <0.00%> (-2.23%) :arrow_down:
pkg/agent/core/ngt/service/option.go 89.57% <0.00%> (-1.85%) :arrow_down:
internal/worker/worker.go 82.30% <0.00%> (-1.54%) :arrow_down:
internal/errgroup/group.go 94.00% <0.00%> (-1.00%) :arrow_down:
internal/core/algorithm/ngt/ngt.go 63.28% <0.00%> (-0.65%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 17 '22 02:08 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d3cb49e
Status: ✅  Deploy successful!
Preview URL: https://e7b1c945.vald.pages.dev
Branch Preview URL: https://feature-continous-benchmark-.vald.pages.dev

View logs