vald
vald copied to clipboard
[Experimental] [WIP] add QUIC support and use netpoll for more efficient network handling
Signed-off-by: kpango [email protected]
Description:
Vald has been working on minimizing the overhead of the network by enhancing the libraries around each network, including gRPC. Recently, the final specification of QUIC has been fixed, and Vald would like to verify the approach of gRPC over QUIC, since it will be in practical use soon. This PR contains the code to verify gRPC over QUIC using quic-go from netpoll and other Network I/O blocking solutions.
Related Issue:
How Has This Been Tested?:
Environment:
- Go Version: 1.16.6
- Docker Version: 19.03.8
- Kubernetes Version: 1.18.2
- NGT Version: 1.12.3
Types of changes:
- [ ] Bug fix [type/bug]
- [ ] New feature [type/feature]
- [ ] Add tests [type/test]
- [ ] Security related changes [type/security]
- [ ] Add documents [type/documentation]
- [ ] Refactoring [type/refactoring]
- [ ] Update dependencies [type/dependency]
- [ ] Update benchmarks and performances [type/bench]
- [ ] Update CI [type/ci]
Changes to Core Features:
- [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your core changes, as applicable?
- [ ] Have you successfully ran tests with your changes locally?
Checklist:
- [ ] I have read the CONTRIBUTING document.
- [ ] I have checked open Pull Requests for the similar feature or fixes?
- [ ] I have added tests and benchmarks to cover my changes.
- [ ] I have ensured all new and existing tests passed.
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have updated the documentation accordingly.
Deploying with
Cloudflare Pages
Latest commit: |
865206c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://4665d6d3.vald.pages.dev |
Branch Preview URL: | https://feature-internal-net-support.vald.pages.dev |
[WARNING:INTCFG] Changes in interal/config
may require you to change Helm charts. Please check.
Codecov Report
Base: 50.23% // Head: 47.63% // Decreases project coverage by -2.61%
:warning:
Coverage data is based on head (
6faac03
) compared to base (97eed29
). Patch coverage: 0.51% of modified lines in pull request are covered.
:exclamation: Current head 6faac03 differs from pull request most recent head 865206c. Consider uploading reports for the commit 865206c to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #1771 +/- ##
==========================================
- Coverage 50.23% 47.63% -2.61%
==========================================
Files 231 212 -19
Lines 13464 10729 -2735
==========================================
- Hits 6764 5111 -1653
+ Misses 6499 5441 -1058
+ Partials 201 177 -24
Impacted Files | Coverage Δ | |
---|---|---|
hack/benchmark/assets/x1b/loader.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/assets/dataset.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/operation/insert.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/operation/operation.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/operation/option.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/operation/remove.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/operation/search.go | 0.00% <ø> (ø) |
|
hack/benchmark/internal/operation/util.go | 0.00% <ø> (ø) |
|
hack/gorules/rules.go | 0.00% <ø> (ø) |
|
hack/license/gen/main.go | 0.00% <0.00%> (ø) |
|
... and 73 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.