vald icon indicating copy to clipboard operation
vald copied to clipboard

[WIP] add values.go implementation

Open kpango opened this issue 2 years ago • 3 comments

Signed-off-by: kpango [email protected]

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • [ ] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have checked open Pull Requests for the similar feature or fixes?
  • [ ] I have added tests and benchmarks to cover my changes.
  • [ ] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

kpango avatar Aug 16 '22 02:08 kpango

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c0582e
Status: ✅  Deploy successful!
Preview URL: https://dedbe9db.vald.pages.dev
Branch Preview URL: https://feature-charts-valuesgo.vald.pages.dev

View logs

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci avatar Sep 07 '22 06:09 vdaas-ci

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.03%. Comparing base (8ec79af) to head (7c0582e). Report is 428 commits behind head on main.

Files Patch % Lines
pkg/agent/sidecar/usecase/sidecar/sidecar.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1770      +/-   ##
==========================================
- Coverage   30.27%   28.03%   -2.24%     
==========================================
  Files         373      348      -25     
  Lines       33713    32573    -1140     
==========================================
- Hits        10207     9133    -1074     
+ Misses      23113    23057      -56     
+ Partials      393      383      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 07 '22 07:09 codecov[bot]