Description:

It merges into PR#1728 branch instead of master branch.

This PR fixes test error from PR#1728. Ref: https://github.com/vdaas/vald/runs/7333833284?check_suite_focus=true

It mainly

fixes tlsHandshake() and cachedDialer() test error
improve test parameters of StartDialerCache

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.18.3
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 1.14.6

Types of changes:

[ ] Bug fix [type/bug]
[ ] New feature [type/feature]
[x] Add tests [type/test]
[ ] Security related changes [type/security]
[ ] Add documents [type/documentation]
[ ] Refactoring [type/refactoring]
[ ] Update dependencies [type/dependency]
[ ] Update benchmarks and performances [type/bench]
[ ] Update CI [type/ci]

Changes to Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have checked open Pull Requests for the similar feature or fixes?
[x] I have added tests and benchmarks to cover my changes.
[x] I have ensured all new and existing tests passed.
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have updated the documentation accordingly.

Jul 14 '22 08:07 kevindiu

[CHATOPS:HELP] ChatOps commands.

:ok_woman: /approve - approve
:love_letter: /changelog - replace the PR body by changelog details
:bento: /format - format codes and add licenses
:white_check_mark: /gen-test - generate test codes
:label: /label - add labels
:rewind: /rebase - rebase master
:end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

Jul 14 '22 08:07 vdaas-ci

Codecov Report

Base: 29.48% // Head: 30.32% // Increases project coverage by +0.84% :tada:

Coverage data is based on head (1b934cc) compared to base (05973a6). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@                                       Coverage Diff                                       @@
##           refactor/internal/add-rename-operation-trying-for-file-copy    #1734      +/-   ##
===============================================================================================
+ Coverage                                                        29.48%   30.32%   +0.84%     
===============================================================================================
  Files                                                              371      373       +2     
  Lines                                                            33296    33838     +542     
===============================================================================================
+ Hits                                                              9816    10262     +446     
- Misses                                                           23098    23170      +72     
- Partials                                                           382      406      +24

Impacted Files	Coverage Δ
internal/info/info.go	`88.82% <100.00%> (+0.05%)`	:arrow_up:
internal/worker/worker.go	`82.30% <0.00%> (-1.54%)`	:arrow_down:
internal/test/goleak/goleak.go
internal/net/dialer.go	`76.94% <0.00%> (ø)`
internal/net/net.go	`85.71% <0.00%> (ø)`
internal/net/option.go	`88.50% <0.00%> (ø)`
internal/errgroup/group.go	`95.00% <0.00%> (+1.00%)`	:arrow_up:
pkg/agent/core/ngt/service/option.go	`91.41% <0.00%> (+1.84%)`	:arrow_up:
internal/net/http/middleware/timeout.go	`93.33% <0.00%> (+2.22%)`	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Jul 14 '22 08:07 codecov[bot]

Deploying with Cloudflare Pages

Latest commit:	`1b934cc`
Status:	✅ Deploy successful!
Preview URL:	https://f0d49c41.vald.pages.dev
Branch Preview URL:	https://test-fix-race-from-1728.vald.pages.dev