vald icon indicating copy to clipboard operation
vald copied to clipboard

Create Continuous Bench Search Job tool

Open vankichi opened this issue 2 years ago • 7 comments

Description:

I have created the PR for the Continours Benchmark Job tool. In this PR, I have implemented the search logic using the fashion-mnist-784-euc dataset.

How Has This Been Tested?:

I have checked in the local vald cluster with k3d + local-registry.

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • [ ] Bug fix [type/bug]
  • [x] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [x] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have checked open Pull Requests for the similar feature or fixes?
  • [ ] I have added tests and benchmarks to cover my changes.
  • [ ] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

vankichi avatar Jul 14 '22 07:07 vankichi

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase master
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Jul 14 '22 07:07 vdaas-ci

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci avatar Jul 14 '22 07:07 vdaas-ci

/format

vankichi avatar Jul 14 '22 07:07 vankichi

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci avatar Jul 14 '22 07:07 vdaas-ci

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/continous-benchmark-tool@48cdb52). Click here to learn what that means. The diff coverage is n/a.

@@                         Coverage Diff                         @@
##             feature/continous-benchmark-tool    #1733   +/-   ##
===================================================================
  Coverage                                    ?   31.66%           
===================================================================
  Files                                       ?      377           
  Lines                                       ?    32243           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    10209           
  Misses                                      ?    21642           
  Partials                                    ?      392           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 14 '22 07:07 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af636ab
Status: ✅  Deploy successful!
Preview URL: https://92db3e90.vald.pages.dev
Branch Preview URL: https://feature-pkg-apis-internal-cr.vald.pages.dev

View logs

And one more thing. I understand you developed aligned with Design doc, but I became thought it's better to change package location to the pkg/tools

pkg/tools/benchmark/job cmd/tools/benchmark/job sounds better because benchmark component is not a main component but for tools for benchmarking, profiling, and so on.

kpango avatar Aug 02 '22 03:08 kpango