vald icon indicating copy to clipboard operation
vald copied to clipboard

add os.Rename try phase for internal/file.CopyWithPerm

Open kpango opened this issue 2 years ago • 5 comments

Signed-off-by: kpango [email protected]

Description:

SSIA

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.6

Types of changes:

  • [ ] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have checked open Pull Requests for the similar feature or fixes?
  • [ ] I have added tests and benchmarks to cover my changes.
  • [ ] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

kpango avatar Jul 06 '22 14:07 kpango

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase master
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Jul 06 '22 14:07 vdaas-ci

Codecov Report

Merging #1728 (4f42380) into master (32b0f83) will increase coverage by 0.13%. The diff coverage is 66.35%.

@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
+ Coverage   31.33%   31.47%   +0.13%     
==========================================
  Files         381      372       -9     
  Lines       32698    30632    -2066     
==========================================
- Hits        10245     9640     -605     
+ Misses      22055    20620    -1435     
+ Partials      398      372      -26     
Impacted Files Coverage Δ
internal/errors/tls.go 0.00% <0.00%> (ø)
internal/file/file.go 11.93% <0.00%> (-0.10%) :arrow_down:
internal/net/grpc/pool/pool.go 0.00% <0.00%> (ø)
internal/strings/strings.go 81.81% <ø> (ø)
internal/test/goleak/goleak.go 0.00% <ø> (ø)
internal/tls/tls.go 79.03% <ø> (ø)
internal/net/net.go 85.71% <50.00%> (-3.39%) :arrow_down:
internal/net/dialer.go 80.33% <78.32%> (-8.39%) :arrow_down:
internal/info/info.go 88.77% <100.00%> (+0.43%) :arrow_up:
internal/net/option.go 88.50% <100.00%> (+0.27%) :arrow_up:
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32b0f83...4f42380. Read the comment docs.

codecov[bot] avatar Jul 06 '22 14:07 codecov[bot]

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/refactor%2Finternal%2Fadd-rename-operation-trying-for-file-copy/52a3566743384ffe499a749402faf27136afd3e8

github-actions[bot] avatar Jul 14 '22 03:07 github-actions[bot]

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

vdaas-ci avatar Jul 14 '22 03:07 vdaas-ci

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4f42380
Status: ✅  Deploy successful!
Preview URL: https://2f03be72.vald.pages.dev
Branch Preview URL: https://refactor-internal-add-rename.vald.pages.dev

View logs