vald icon indicating copy to clipboard operation
vald copied to clipboard

[WIP] add values.go implementation

Open kpango opened this issue 2 years ago • 3 comments

Signed-off-by: kpango [email protected]

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.5

Types of changes:

  • [ ] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [ ] Have you written new tests for your core changes, as applicable?
  • [ ] Have you successfully ran tests with your changes locally?

Checklist:

  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have checked open Pull Requests for the similar feature or fixes?
  • [ ] I have added tests and benchmarks to cover my changes.
  • [ ] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

kpango avatar Jun 06 '22 11:06 kpango

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase master
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Jun 06 '22 11:06 vdaas-ci

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

vdaas-ci avatar Jun 06 '22 11:06 vdaas-ci

Codecov Report

Merging #1692 (c818af3) into master (9ea85a3) will decrease coverage by 2.31%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   31.67%   29.35%   -2.32%     
==========================================
  Files         385      360      -25     
  Lines       32713    31526    -1187     
==========================================
- Hits        10362     9256    -1106     
+ Misses      21955    21881      -74     
+ Partials      396      389       -7     
Impacted Files Coverage Δ
pkg/agent/core/ngt/config/config.go 68.96% <ø> (ø)
pkg/agent/sidecar/config/config.go 0.00% <ø> (ø)
pkg/agent/sidecar/usecase/sidecar/sidecar.go 0.00% <0.00%> (ø)
pkg/gateway/filter/config/config.go 0.00% <ø> (ø)
pkg/gateway/lb/config/config.go 0.00% <ø> (ø)
pkg/manager/index/config/config.go 0.00% <ø> (ø)
internal/worker/worker.go 82.81% <0.00%> (-0.79%) :arrow_down:
internal/core/algorithm/ngt/ngt.go 64.70% <0.00%> (-0.66%) :arrow_down:
internal/config/compress.go
internal/config/http.go
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9c8a6a...c818af3. Read the comment docs.

codecov[bot] avatar Jun 06 '22 11:06 codecov[bot]