vald icon indicating copy to clipboard operation
vald copied to clipboard

[Pending] Fix internal/runner race error

Open kevindiu opened this issue 2 years ago • 3 comments

Signed-off-by: kevindiu [email protected]

Description:

This PR fixes internal/runner package error by using CAS operation to set time.Local. This PR also move implementation & test code to its appropriate file.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.3

Types of changes:

  • [x] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [x] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you written new tests for your core changes, as applicable?
  • [x] Have you successfully ran tests with your changes locally?

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] I have checked open Pull Requests for the similar feature or fixes?
  • [x] I have added tests and benchmarks to cover my changes.
  • [x] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

kevindiu avatar Apr 26 '22 03:04 kevindiu

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase master
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Apr 26 '22 03:04 vdaas-ci

Codecov Report

Merging #1635 (a25ad0c) into master (3227058) will increase coverage by 0.49%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
+ Coverage   31.25%   31.75%   +0.49%     
==========================================
  Files         346      370      +24     
  Lines       27657    32308    +4651     
==========================================
+ Hits         8644    10259    +1615     
- Misses      18749    21652    +2903     
- Partials      264      397     +133     
Impacted Files Coverage Δ
internal/timeutil/location/loc.go 90.00% <83.33%> (-10.00%) :arrow_down:
internal/worker/worker.go 83.59% <0.00%> (ø)
internal/core/algorithm/ngt/ngt.go 63.59% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 20.22% <0.00%> (ø)
hack/benchmark/internal/core/algorithm/ngt/ngt.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/linear_search.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/router/router.go 100.00% <0.00%> (ø)
internal/core/algorithm/ngt/option.go 58.17% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/search.go 24.12% <0.00%> (ø)
pkg/agent/core/ngt/usecase/agentd.go 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 003f80d...a25ad0c. Read the comment docs.

codecov[bot] avatar Apr 26 '22 03:04 codecov[bot]

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a25ad0c
Status: ✅  Deploy successful!
Preview URL: https://3d316843.vald.pages.dev
Branch Preview URL: https://test-fix-location-set-race.vald.pages.dev

View logs