vald icon indicating copy to clipboard operation
vald copied to clipboard

[Pending] Fix singleflight race

Open kevindiu opened this issue 3 years ago • 2 comments

Signed-off-by: kevindiu [email protected]

Description:

This PR fixes singleflight race error.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.17.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.13.7

Types of changes:

  • [x] Bug fix [type/bug]
  • [ ] New feature [type/feature]
  • [ ] Add tests [type/test]
  • [ ] Security related changes [type/security]
  • [ ] Add documents [type/documentation]
  • [ ] Refactoring [type/refactoring]
  • [ ] Update dependencies [type/dependency]
  • [ ] Update benchmarks and performances [type/bench]
  • [ ] Update CI [type/ci]

Changes to Core Features:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you written new tests for your core changes, as applicable?
  • [x] Have you successfully ran tests with your changes locally?

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] I have checked open Pull Requests for the similar feature or fixes?
  • [x] I have added tests and benchmarks to cover my changes.
  • [x] I have ensured all new and existing tests passed.
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the documentation accordingly.

kevindiu avatar Nov 16 '21 08:11 kevindiu

[CHATOPS:HELP] ChatOps commands.

  • :ok_woman: /approve - approve
  • :love_letter: /changelog - replace the PR body by changelog details
  • :bento: /format - format codes and add licenses
  • :white_check_mark: /gen-test - generate test codes
  • :label: /label - add labels
  • :rewind: /rebase - rebase master
  • :end: :two: :end: /label actions/e2e-deploy - run E2E deploy & integration test

vdaas-ci avatar Nov 16 '21 08:11 vdaas-ci

Codecov Report

Merging #1499 (19c908f) into master (c4768a7) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
+ Coverage   30.51%   30.56%   +0.05%     
==========================================
  Files         372      373       +1     
  Lines       32212    32238      +26     
==========================================
+ Hits         9828     9853      +25     
+ Misses      22020    22019       -1     
- Partials      364      366       +2     
Impacted Files Coverage Δ
internal/singleflight/singleflight.go 100.00% <100.00%> (ø)
...nt/core/ngt/service/vqueue/uninserted_index_map.go 64.48% <0.00%> (-8.75%) :arrow_down:
internal/worker/worker.go 84.37% <0.00%> (+0.78%) :arrow_up:
pkg/agent/core/ngt/service/ngt.go 20.44% <0.00%> (+1.11%) :arrow_up:
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d1f0b7...19c908f. Read the comment docs.

codecov[bot] avatar Nov 16 '21 08:11 codecov[bot]