modV icon indicating copy to clipboard operation
modV copied to clipboard

feat(isf-fft): adds fft into the renderers for use in ISF

Open TimPietrusky opened this issue 2 years ago • 5 comments

  • Fixes #639

TimPietrusky avatar Oct 24 '21 15:10 TimPietrusky

@2xAA what was the reason that this is still a draft? I can't remember anymore :D

TimPietrusky avatar Mar 02 '22 20:03 TimPietrusky

@TimPietrusky I think we were waiting for the new build and audio support of our fork of ISF, but I can't be quite sure at this point.

Does this PR work? If so, I don't see why we need to keep it a draft.

2xAA avatar Mar 02 '22 23:03 2xAA

I was using this branch in combination with next for all my shows, it works super good with the fixed we did last night.

It still just points to a specific commit of our fork https://github.com/vcync/interactive-shader-format-js/commit/78b62b6f4c787b870852df4c8e7b1131e331d8a6 but as we are not putting any time in the fork, I think this is still the way to go to get audio into ISF.

TimPietrusky avatar Aug 10 '22 20:08 TimPietrusky

@TimPietrusky I think we need to merge next into this before proceeding - there are some changes here which seem to have already been merged, specifically around the audio smoothing.

2xAA avatar Aug 19 '22 08:08 2xAA

@TimPietrusky maybe we don't need to use a texture after all? Could speed up operations. https://stackoverflow.com/questions/7709689/webgl-pass-array-shader

2xAA avatar Sep 13 '22 21:09 2xAA

:tada: This PR is included in version 3.25.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

2xAA avatar Nov 01 '22 22:11 2xAA