Vladimír Čunát

To be clear, this is with pypcap-1.3.0 although the tag is missing in this repo.

I think the git `CommitDate` is closest value to what I'd like to see (which is "push date"). Note that this is distinct from `AuthorDate`, i.e. the default date shown...

> uint64_t* reserved[13]; So the structure has three uint64_t and then 13 pointers? That feels really weird on 32-bit platforms. Did you mean to use this? ```c uint64_t reserved[13]; ```...

Then I suggest at least a comment in the struct to warn about changing/unreserving, as that won't be easy to do while keeping *both* 32-bit and 64-bit struct lengths.

You were also discussing it during review but noone seems to have noticed 🤷🏽 > though the struct length will be a PITA to keep when "unreserving" in future Actually,...

Testing UINTPTR_MAX feels ugly, but off the top of my head I don't know a better _preprocessor_ symbol. I meant e.g. https://github.com/libuv/libuv/commit/b6bf6d2d1f4c4ec263ee9064060e983ac3ee555f

doh and netmgr tests seem to occasionally fail on x86_64-linux as well. I remember restarting these; but relatively rarely, fortunately.

I can't take it anymore. I disabled the tests now (d7d6471a6958). Feel free to do partial test instead of full disabling, or anything that's relatively reliable. EDIT: it was still...

Some default to docutils 0.19 now, which also fails this condition though I haven't encountered an issue with the combination.

Nitpick: the link you provided wasn't the last version; that's probably here: https://tools.ietf.org/html/draft-ietf-tls-esni (just clicked a few times, no deep knowledge; EDITed as suggested, and it's in OP now anyway)