Stop adding description

Open krachynski opened this issue 1 year ago • 4 comments

fixes #257

This code was adding the AzureSignTool Command.Description to the signed file. Sending null allows the codesigning to reuse the existing description.

Jun 18 '24 17:06 krachynski

Err. I mean it's grabbing the Command.Description and overriding the data in the file being signed.

Jun 18 '24 18:06 krachynski

I think this was a bug in 5.0.0. I don't think we should stop setting Description all together. Can you try building from main and see if AST properly uses Description (-d)?

Jun 22 '24 20:06 vcsjones

This was from main.

If you have a better way to handle this, I'm open to suggestions. This fixed my fork for my needs.

Jul 02 '24 14:07 krachynski

PS: The original code is adding the Command.Description ("Sign a file.") to the signed object. Which isn't correct in itself.

Jul 03 '24 15:07 krachynski