AzureSignTool icon indicating copy to clipboard operation
AzureSignTool copied to clipboard

Run the Sign function in an STA thread to be able to sign js files

Open air2 opened this issue 1 year ago • 6 comments

Implements the fix proposed by @engycz in #169

air2 avatar Jun 18 '24 06:06 air2

Interesting. Thanks for the fix. I am going to play around with this locally first to make sure I understand.

vcsjones avatar Jun 22 '24 20:06 vcsjones

bump?

ncook-hxgn avatar Nov 14 '24 12:11 ncook-hxgn

Bumping for update. Hopefully this can make it into the next release.

eponerine avatar Dec 10 '24 19:12 eponerine

I haven't forgotten about this pull request. I do have some concerns about spawning potentially 1000s of threads. I realize that with the Join there will never be more then MDOP number of executing threads, but constantly creating and destroying threads makes memory usage a tad high.

Right now I am experimenting with a custom TaskScheduler for Parallel.ForEach instead. If I put together a branch with a task scheduler would folks be willing to pull it down, build AzureSignTool, and give it a try?

vcsjones avatar Dec 16 '24 20:12 vcsjones

Sure thing! We're already running @air2 branch "in production" and its working. We are willing to try an official release so we don't have to maintain our own copy of code internally.

eponerine avatar Dec 16 '24 21:12 eponerine

Anyone going to finish this pull?

DarkestFM avatar Apr 04 '25 14:04 DarkestFM