vcspull icon indicating copy to clipboard operation
vcspull copied to clipboard

No URL found for submodules breaks the pull

Open rogerioefonseca opened this issue 2 years ago • 5 comments

Hello there, While trying to use vcspull I noticed that it breaks and stops when a submodule is miss configured or does not exist. Maybe would be better to validate the configuration and if it passes continue with the checkout and if not, warn the user and continue to checkout the next repo.

image

rogerioefonseca avatar Apr 08 '22 12:04 rogerioefonseca

there is a plan to do config validation in 2.0.0 as there will be a major config format rework done in that version.

@tony i guess submodule handling is entirely done in libvcs?

MfG Andreas "Segaja" Schleifer

aschleifer avatar Apr 08 '22 13:04 aschleifer

@rogerioefonseca @aschleifer

It is in the early stages, under the hood I am updating/untangling libvcs to address this.

  1. libvcs run() will support deferred execution and return a class so its more introspectable in tests and commands
  2. there will be a core Git command wrapper: https://github.com/vcs-python/libvcs/pull/319
  3. there will be a way to continue_on_error that can pass directly through via the config (still not sure what the signature will look like)

tony avatar Apr 09 '22 17:04 tony

Related: #363 continue on error

tony avatar Apr 11 '22 10:04 tony

@rogerioefonseca I would need the full traceback of this to see the codepath where the exception was raised.

Sorry for the delay.

I can't quite recreate this exactly. I will make a PR where I've taken a stab

tony avatar Sep 25 '22 17:09 tony

@rogerioefonseca I created #391, I can't recreate it, but had some test code out there that you can look at - which may be close to recreating

tony avatar Sep 25 '22 19:09 tony