vcrhonek
Install original pnp data
Hi
I'm packaging a project that depends on the pnp.ids list, and this repo providing a stable version of is exactly what I'm looking for. The issue is that this project expects the list in the original HTML form as an input to do its own processing.
This PR adds pnp.ids.xlsx to the list of tracked outputs.
Thanks :)
Hi @emilytrau ,
Thanks for your PR. I'd like you to fix few issues I noticed please:
- remove modification of 'pnp.ids' file from the commit
- remove 'pnp.ids.xlsx' file from 'clean' target in Makefile
- add '%exclude %{_datadir}/%{name}/pnp.ids.xlsx' into hwdata.spec: %{_datadir}/%{name}/* +%exclude %{_datadir}/%{name}/pnp.ids.xlsx %{_datadir}/pkgconfig/%{name}.pc
In general, I don't exactly like the idea of installing additional file that seems to have very limited use (I mean, it seems to be useful just for you project as far as I know:)). On the other hand, distribution maintainers can simply remove it in similar manner as I will do for Fedora in the spec file.
I'm not sure... maybe it would be cleaner to add configure option that would add pnp.ids.xlsx to the list of installed files only when requested?
