Valentin Churavy comments

Results 1415 comments of


                                            Valentin Churavy

Why does `Duplicated(x, dx)` assume `x` and `dx` have the same type?

We also assume congruency https://github.com/EnzymeAD/Enzyme.jl/issues/636 i.e. that the shadow is structurally identically to the primal value. This is not a requirement on the Julia types, but on the datalayout of...

Something invalidating `Enzyme.init` causes a heavy package load time penalty

I am not sure that fixed all instances. Need to confirm with an actual profile

Something invalidating `Enzyme.init` causes a heavy package load time penalty

> Yeah disabling optimizations seems like a bad idea. I think disabling optimizations for the registration functions should be fine. But I wonder if it impacts the callbacks, if it...

Something invalidating `Enzyme.init` causes a heavy package load time penalty

Concretly we are spending ~30s on compiling init ![image](https://github.com/EnzymeAD/Enzyme.jl/assets/145258/92e4a63d-3d1e-4acf-8bda-9726835f2ea2)

Add Julia formatter

Can we merge the Formatter on its own and slowly apply the suggested changes? Right now this will cause large conflicts with other PRs. I think `clang-format` can do this...

Add Julia formatter

Thanks! Lets see how this does and if it is to annoying we may disable it.

Add Julia formatter

As an example see https://github.com/EnzymeAD/Enzyme.jl/pull/1302 where the changes themselves will be formatted. So slowly over time the code base will match the format rules, but without the cost of having...

Memoize typetree calls

Seems to be an about 10s speedup. @wsmoses is there a way to query the tree depth allowed?

Adding MPI test

Can you rebase once more?

Try nightly

Closed in favor off #1372