Valentin Churavy

Results 1411 comments of Valentin Churavy

Warnings during init are incredibly obnoxious. I agree with @gdalle that the most likely consequences is people just not using Enzyme. The 1.11 warning we could add to the readme

Perhaps as an error hint? There is some experimental facility for that, but I haven't worked with that yet. > My other worry is that if folks already ignore warnings...

Also sometimes people are okay with things being slow if they are more convenient. So I am much less concerned about that.

> it is my intention to eventually replace this with a GOT/PLT mechanism that will also allow us to start running code before all of the edges are compiled. @pchintalapudi...

If anyone is interested in adding it, it would probably mean adding `uv_fsync` (see https://docs.libuv.org/en/v1.x/fs.html) to https://github.com/JuliaLang/julia/blob/2a920801860621fcfdd4c672c7533592aa06bba3/src/jl_uv.c#L586 And then exposing that in Julia proper

Please isolate this to a fully JACC free MWE. The changes in 1.3.4 are very limited https://github.com/JuliaGPU/AMDGPU.jl/releases/tag/v1.3.4 and the most likely to be relevant one is #783 which adds memory...

So part of the issue seems around zeroinit which is not a part of the code I am super familiar with. Some of it seems indeed quite strange https://github.com/JuliaGPU/AMDGPU.jl/blob/4e5ee8edbbea3e471ac17ba2dd5c99c6ad6b77fb/src/device/gcn/memory_static.jl#L84 For...

I mean... That kinda seems correct? It could answer with the CPU backend?