Valentin Breuß

Results 79 comments of Valentin Breuß

> Not sure I get you. > I didn't mean rename `SubsequentOrderingAssertions` to `SubsequentOrderingGenericCollectionAssertions`, but let the relevant assertions in `GenericCollectionAssertions` return `SubsequentOrderingGenericCollectionAssertions` instead of `SubsequentOrderingAssertions`. That would practically be...

These methods come from set theory, but work on `IEnumerable`. What happens when duplicate entries are provided in the subject or the expected value? I would expect duplicate entries to...

> I like your library a lot! I'm wondering whether it would make sense if you implement the System.IO.Abstractions interfaces instead of duplicating them. In that case I'd be happy...

> @vbreuss Any chance to go forward on this ? If you cannot work on it at the moment, I can take over it. Would you mind ? @arkiaconsulting :...

I'm not sure. It's more a refactoring change missing a review from @jnyrup. I can rebase the branch, or abandon the PR.

@cryolithic : I am afraid, that we don't have any options to resolve your issue. - We intentionally changed the return type to a custom Stream class due to #779....

@cryolithic: Unfortunately I underestimated this impact in #906 and didn't mark it explicitely as breaking change in itself, so the major version got bumped due to the refactoring in general,...

@AnakinRaW : Are you sure, your test is correct? The provided input `"d:test.txt"` is no valid (rooted) path. Maybe it should be `@"d:\test.txt"` instead?

Thanks for the clarification, @AnakinRaW ! I was not aware of this format, but after looking around, it is also documented in the [File path formats on Windows systems](https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats#traditional-dos-paths) :-)

Discussion with some arguments started in https://github.com/Testably/Testably.Abstractions/issues/460.