Lint, tidy and use C++20 features

[elazarg]

This PR serves as a demonsration, and is unlikely to be merged, since it's far too large and not really automatable.

Summary by CodeRabbit

• New Features

  • Added new template functions for creating std::vector<T> from various data sources, enhancing type safety and usability.

• Improvements

  • Updated several functions to use const references for parameters, enhancing performance and clarity.
  • Simplified function signatures and enhanced readability with modern C++ features like structured bindings and range-based algorithms.
  • Improved type safety and clarity in function signatures across multiple files.
  • Enhanced the string_invariant struct with default equality operator and updated contains method for better performance.

• Refactor

  • Removed unnecessary complexity and improved type safety by standardizing type usage.
  • Streamlined various classes and functions to enhance maintainability and readability.
  • Removed deprecated methods and classes to simplify the API.
  • Enhanced const-correctness across multiple files to prevent unintended modifications.
  • Renamed z_number class to number_t for consistency and clarity.

[coveralls]

coverage: 90.374% (-0.04%) from 90.41% when pulling 5203019aa0cded86f58a5aedc80d4b79522e9784 on modernize-c++20 into 6d5631c5ac0b8b4279478f4e0adb0cfdcba7f305 on main.

[elazarg]

@coderabbitai review

[coderabbitai[bot]]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai[bot]]

[!WARNING]

Rate limit exceeded

@elazarg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 11 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9f9cbf10a82d9bfe38ffb59ded0215f33e665f22 and 5203019aa0cded86f58a5aedc80d4b79522e9784.

Walkthrough

The changes involve extensive modifications across multiple source files, primarily focusing on enhancing type safety, improving code clarity, and adopting modern C++ features. Key updates include the introduction of const qualifiers, the use of std::ranges, and the implementation of new template functions. Additionally, several functions have been refactored to improve parameter handling and reduce unnecessary copies, while some files have been removed to streamline the codebase.

Changes

Files	Change Summary
src/.../asm_cfg.cpp, src/.../asm_files.cpp, src/.../asm_marshal.cpp, src/.../asm_ostream.cpp, src/.../asm_parse.cpp	Modifications to function signatures to include const references, enhancing const-correctness. Adoption of modern C++ features like std::ranges and structured bindings. Updates to improve type safety and code clarity.
src/.../asm_files.hpp, src/.../asm_ostream.hpp, src/.../crab_utils/stats.hpp	Introduction of new template functions for creating vectors from raw data, and updates to function signatures for clarity. Changes include renaming parameters and enhancing type safety.
src/.../crab_utils/stats.cpp, src/.../linux/linux_platform.cpp	Enhancements in type handling, removal of unused methods, and updates to improve parameter readability. Changes to ensure const-correctness and modern C++ practices.
test-data/.../stack.yaml	Addition of a new entry defining a range of numbers for testing, enhancing the configuration for data handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System
    User->>System: Call function with parameters
    System->>System: Process parameters with const references
    System->>System: Utilize modern C++ features
    System->>User: Return results

🐰 "In the code where bunnies hop,
Changes made, we won't stop!
With const and moves, we leap so high,
Modern C++ makes us fly!
From functions bright to types so neat,
Our code is now a tasty treat!"
🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example: -- I pushed a fix in commit <commit_id>, please review it. -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples: -- @coderabbitai generate unit testing code for this file. -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -- @coderabbitai read src/utils.ts and generate unit testing code. -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.