ebpf-verifier icon indicating copy to clipboard operation
ebpf-verifier copied to clipboard

Remove file glob entries in cmakefiles.txt and specify sources explicitly instead

Open poornagmsft opened this issue 4 years ago • 1 comments

cmake recommendation is to not use file (glob)

poornagmsft avatar Jan 05 '21 01:01 poornagmsft

Poorna pointed me to https://cmake.org/cmake/help/latest/command/file.html which says:

Note

We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate. The CONFIGURE_DEPENDS flag may not work reliably on all generators, or if a new generator is added in the future that cannot support it, projects using it will be stuck. Even if CONFIGURE_DEPENDS works reliably, there is still a cost to perform the check on every rebuild.

dthaler avatar Jan 05 '21 04:01 dthaler