Vladimir Blagojevic
Vladimir Blagojevic
How about we update the main with this simple and clear change first https://github.com/deepset-ai/haystack/compare/main...remove_template_params_from_kwargs add unit tests, and then after that, we can continue on with different changes on all...
> ok, the problem is that we only remove the parameters existing in the PromptTemplate and `query` is not one of those parameters as can be seen from the prompt...
As this change might have some unintended consequences @faaany , let me look through everything once again and perhaps add some tests. I'll update PR with my comments tomorrow.
@anakin87 would you please have a look at this PR? The objective is to remove kwargs filters in HFLocalInvocationLayer invoke. They change from release to release and often block users...
Thanks for these updates @faaany . I'm consulting internally about the potentially unforeseen impact of these changes. One of the changes we are introducing with this PR is the following:...
@malte-aws, thanks for these contributions. There seem to be several topics for discussion here. We could continue discussing here or arrange a quick sync call where @anakin87, you and I...
> > @malte-aws, thanks for these contributions. There seem to be several topics for discussion here. We could continue discussing here or arrange a quick sync call where @anakin87, you...
Hey @CarlosFerLo @julian-risch @Phlasse Just saw your PR contribution @CarlosFerLo - thank you. I was wondering why not, if we are already adding another init parameter, make it more powerful...
@CarlosFerLo I'm suggesting we don't use `keep_id` flag because `id_generator` callable can replace it and future use cases where people want to customize doc id generation. We can then use...
@CarlosFerLo a class in our design principles would be an overkill. A simple [Callable](https://docs.python.org/3/library/typing.html#annotating-callable-objects) suffices here. See in these docs how you can specify the input parameters and return values....