Koichi Akabe comments

Results 25 comments of


                                            Koichi Akabe

DoubleArray::new() does not check untrusted source

SGTM.

Example fails

Maybe, "--use-system-libs" should support multiarch. Currently, this option just adds "/lib" and "/usr/lib" to LD_LIBRARY_PATH, but libc.so is installed in /lib/x86_64-linux-gnu in the latest Debian 64bit. When you run the...

Providing wheels that are incompatible with PEP 513

To benefit from PyPI and `pip` framework, I think the best method is providing a source package. PyPI and `pip` are maintained on the assumption that we follow `manylinux1` policy....

Very slow deserialization

@ezkangaroo The DoubleArrayAhoCorasick structure internally uses unsafe functions, so I don't want to implement Serialize and Deserialize traits. Instead, it is possible to use serde internally and provide a deserialization...

Very slow deserialization

Tip. Although deserialize itself is a safe process, there is no guarantee that the automaton is correct, and in some cases memory access violations will occur, so the function must...