feat: adding tokio::io implementing AsyncRead + AsyncWrite
@vavrusa First off, thank you for your excellent contribution towards the Rust Dev community - memcache-async.
For compatibility, I'm adding tokio::io based AsyncWrite and AsyncRead implementations along with existing futures::io which remains as library default and uninterrupted.
Rationale -- any clients using memcache-async directly need not write a Compat layer based on futures::io::{AsyncWrite, AsyncRead} for consuming memcache-async. But instead, allow users to choose between the AsyncWrite and AsyncRead features like so:
feature = "with-futures"
[dependencies]
memcache-async = "0.8.0"
or
[dependencies]
memcache-async = { version="0.8.0", features=["with-futures"] }
feature = "with-tokio"
[dependencies]
memcache-async = { version="0.8.0", features=["with-tokio"] }
Hi, thanks! This seems fine, can you rebase and bump the version please?
@vavrusa its resolved. Please check again. Thank you!
@vavrusa please let me know if this looks good.
@vavrusa following up again. LMK if the changes are okay now.
@vavrusa hey just checking in to see if my message was missed.
@vavrusa any updates in checking this PR?
Thanks!