memcache-async icon indicating copy to clipboard operation
memcache-async copied to clipboard

feat: adding tokio::io implementing AsyncRead + AsyncWrite

Open vaikzs opened this issue 1 year ago • 5 comments

@vavrusa First off, thank you for your excellent contribution towards the Rust Dev community - memcache-async.

For compatibility, I'm adding tokio::io based AsyncWrite and AsyncRead implementations along with existing futures::io which remains as library default and uninterrupted.

Rationale -- any clients using memcache-async directly need not write a Compat layer based on futures::io::{AsyncWrite, AsyncRead} for consuming memcache-async. But instead, allow users to choose between the AsyncWrite and AsyncRead features like so:

feature = "with-futures"

[dependencies]
memcache-async = "0.8.0"

or

[dependencies]
memcache-async = { version="0.8.0", features=["with-futures"] }

feature = "with-tokio"

[dependencies]
memcache-async = { version="0.8.0", features=["with-tokio"] }

vaikzs avatar May 27 '24 22:05 vaikzs

Hi, thanks! This seems fine, can you rebase and bump the version please?

vavrusa avatar Jun 06 '24 22:06 vavrusa

@vavrusa its resolved. Please check again. Thank you!

vaikzs avatar Jun 07 '24 03:06 vaikzs

@vavrusa please let me know if this looks good.

vaikzs avatar Jun 16 '24 06:06 vaikzs

@vavrusa following up again. LMK if the changes are okay now.

vaikzs avatar Jul 05 '24 22:07 vaikzs

@vavrusa hey just checking in to see if my message was missed.

vaikzs avatar Jul 22 '24 07:07 vaikzs

@vavrusa any updates in checking this PR?

vaikzs avatar Aug 23 '24 05:08 vaikzs

Thanks!

vavrusa avatar Sep 04 '24 17:09 vavrusa