Henrique Mouta
Henrique Mouta
Oh - I also renamed the component from `excerpt-generator` to `excerpt-suggestions` on a different commit 🙂
@acicovic I believe I addressed all your feedback! Let me know if you have any additional thoughts 🙂 I believe since you're the owner of this PR, you can't approve...
> Do you think that the current change could be characterized as a breaking change? Currently, as it is, not really. I have only changed the tests to be PSR-4...
@acicovic added one last commit that was not pushed by mistake. Care to take a quick look before merging?
@coderabbitai pause
Closed per #2693
Closed in favour of #2923
I believe this should be either part of #2426, or done before that work, since all the PHP refactoring work will very much benefit from this change. What do you...
Yeah, agree! In that case, I think I will take this one before spending too much time on #2426. I **think** it could be a relatively easy win.
Agreed! I think we can safely remove the `tests` directory, and all the `ts`, `tsx`, and `scss` files from the built version, since essentially those are bundled in the `build/`...