sos icon indicating copy to clipboard operation
sos copied to clipboard

trunk_size should be chunk_size

Open BoPeng opened this issue 3 years ago • 4 comments

Not sure why option trunk_size was chosen but it should be chunk_size or batch_size, I think.

BoPeng avatar Feb 01 '22 00:02 BoPeng

trunk_size and trunk_workers? I thought that was one of your analogies of a collection of parallel branches of jobs from a "trunk". I've became used to these parameter names.

gaow avatar Feb 01 '22 01:02 gaow

I guess I had "chunk" in mind but used "trunk" without further thinking. batch_size might be more appropriate anyway.

BoPeng avatar Feb 01 '22 01:02 BoPeng

batch is better. But it would be best if we keep the backward compatibility of trunk

gaow avatar Feb 01 '22 01:02 gaow

Of course we will if I ever change the parameter name.

BoPeng avatar Feb 01 '22 01:02 BoPeng