typedb-docs icon indicating copy to clipboard operation
typedb-docs copied to clipboard

Missing documented functions

Open snowparrot opened this issue 5 years ago • 3 comments

Description

I tried to use the attributes method on an Entity but the code throw an exception. During the bug search, I found out, there is no implementation on the python client for the attributes method for Things in Concept.py in opposite to the documentation! (https://dev.grakn.ai/docs/concept-api/thing)

Environment

OS (where Grakn server runs): Fedora 32 Grakn version (and platform): Grakn Core 1.8 3. Grakn client-python version: client-python 1.8 4. Python version: 3.7 4. Other environment details:

Reproducible Steps

Check https://github.com/graknlabs/client-python/blob/master/grakn/service/Session/Concept/Concept.py between lines between 150 and 166.

snowparrot avatar Aug 06 '20 13:08 snowparrot

I believe the documentation is not clear enough about the distinction between local and remote concepts - local concepts are value objects that can't really do anything. If you want to do remote server operations as listed in the docs, you first need to convert the concept to a Remote concept using concept.as_remote(tx)

flyingsilverfin avatar Aug 21 '20 11:08 flyingsilverfin

To be honest I found this distinction when I read the code, not the docs...

So this should be added. Thank u for ur answer!

snowparrot avatar Aug 21 '20 11:08 snowparrot

Given that all docs are stored in graknlabs/docs, I'm transferring the issue there.

vmax avatar Sep 07 '20 09:09 vmax