bazel-distribution icon indicating copy to clipboard operation
bazel-distribution copied to clipboard

Rename all `assemble` and `deploy` rules: `maven_assembly`; `npm_deployment`, etc.

Open alexjpwalker opened this issue 3 years ago • 3 comments

The top-level packages are named npm, pip, maven etc. while the rule names begin with assemble and deploy - there is a misalignment here.

alexjpwalker avatar Jan 10 '22 16:01 alexjpwalker

npm, pip etc. are clearly stronger domains than assemble and deploy. This gives us maven_assemble.

Now, assemble and deploy are verbs, which does not really fit the paradigms of a declarative language like Bazel.

So the refactor we're leaning towards is:

  • assemble_maven => maven_assembly
  • deploy_maven => maven_deployment
  • assemble_pip => pip_assembly
  • deploy_npm => npm_deployment

(and so on and so forth.)

alexjpwalker avatar Jan 11 '23 18:01 alexjpwalker

Let's make this change once we condense the GitHub repos, so that it's easier to propagate. cc @haikalpribadi .

alexjpwalker avatar Jan 12 '23 10:01 alexjpwalker

Indeed, let's rename them, but after we collapse the repositories.

haikalpribadi avatar Jan 12 '23 22:01 haikalpribadi