xen-orchestra
xen-orchestra copied to clipboard
fix(backups): keep only the last snapshot across all delta schedules
in case the user doesn't use rolling snapshots Before this commit, it was keeping one snapshot per schedule
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
- Commit
- Title follows commit conventions
- Reference the relevant issue (
Fixes #007
,See xoa-support#42
,See https://...
) - If bug fix, add
Introduced by
- Changelog
- If visible by XOA users, add changelog entry
- Update "Packages to release" in
CHANGELOG.unreleased.md
- PR
- If UI changes, add screenshots
- If not finished or not tested, open as Draft
Review process
This 2-passes review process aims to:
- develop skills of junior reviewers
- limit the workload for senior reviewers
- limit the number of unnecessary changes by the author
- The author creates a PR.
- Review process:
- The author assigns the junior reviewer.
- The junior reviewer conducts their review:
- Resolves their comments if they are addressed.
- Adds comments if necessary or approves the PR.
- The junior reviewer assigns the senior reviewer.
- The senior reviewer conducts their review:
- If there are no unresolved comments on the PR → merge.
- Otherwise, we continue with 3.
- The author responds to comments and/or makes corrections, and we go back to 2.
Notes:
- The author can request a review at any time, even if the PR is still a Draft.
- In theory, there should not be more than one reviewer at a time.
- The author should not make any changes:
- When a reviewer is assigned.
- Between the junior and senior reviews.