xen-orchestra
xen-orchestra copied to clipboard
feat(lite/component): UiSpinner
Check list
Check if done, if not relevant leave unchecked.
- [ ] PR reference the relevant issue (e.g.
Fixes #007
orSee xoa-support#42
) - [ ] if UI changes, a screenshot has been added to the PR
- [ ] documentation updated
-
CHANGELOG.unreleased.md
:- [ ] enhancement/bug fix entry added
- [ ] list of packages to release updated (
${name} v${new version}
)
-
I have tested added/updated features (and impacted code)
- [ ] unit tests (e.g.
cron/parse.spec.js
) - [ ] if
xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
- [ ] at least manual testing
- [ ] unit tests (e.g.
Process
- create a PR as soon as possible
- mark it as
WiP:
(Work in Progress) if not ready to be merged - when you want a review, add a reviewer (and only one)
- if necessary, update your PR, and re- add a reviewer
From the Four Agreements:
- Be impeccable with your word.
- Don't take anything personally.
- Don't make assumptions.
- Always do your best.
I make it so the spinner act as an icon (like <FontAwesomeIcon :icon="spinner" spin />
).
I thought it would be much more flexible if it adjusted its size according to the font-size.
Moreover, it will be used in the UiIcon
component <UiIcon :icon="faSomething" :busy="isBusy" />
and therefore will have the same size of the icon (which takes the size of the text).