xen-orchestra icon indicating copy to clipboard operation
xen-orchestra copied to clipboard

feat(lite/component): UiSpinner

Open ByScripts opened this issue 2 years ago • 1 comments

Capture 2022-09-16 at 19 10 46

Check list

Check if done, if not relevant leave unchecked.

  • [ ] PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • [ ] if UI changes, a screenshot has been added to the PR
  • [ ] documentation updated
  • CHANGELOG.unreleased.md:
    • [ ] enhancement/bug fix entry added
    • [ ] list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)
    • [ ] unit tests (e.g. cron/parse.spec.js)
    • [ ] if xo-server API changes, the corresponding test has been added to/updated on xo-server-test
    • [ ] at least manual testing

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

ByScripts avatar Sep 16 '22 17:09 ByScripts

I make it so the spinner act as an icon (like <FontAwesomeIcon :icon="spinner" spin />).

I thought it would be much more flexible if it adjusted its size according to the font-size.

Moreover, it will be used in the UiIcon component <UiIcon :icon="faSomething" :busy="isBusy" /> and therefore will have the same size of the icon (which takes the size of the text).

ByScripts avatar Sep 20 '22 13:09 ByScripts