xen-orchestra icon indicating copy to clipboard operation
xen-orchestra copied to clipboard

feat(xolite): display ram usage from pool dashboard

Open MathieuRA opened this issue 3 years ago • 3 comments

Screenshot

Capture d’écran de 2022-09-13 14-39-04

Check list

Check if done, if not relevant leave unchecked.

  • [ ] PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • [x] if UI changes, a screenshot has been added to the PR
  • [ ] documentation updated
  • CHANGELOG.unreleased.md:
    • [ ] enhancement/bug fix entry added
    • [ ] list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)
    • [ ] unit tests (e.g. cron/parse.spec.js)
    • [ ] if xo-server API changes, the corresponding test has been added to/updated on xo-server-test
    • [x] at least manual testing

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

MathieuRA avatar Sep 13 '22 12:09 MathieuRA

Nice! What's the behavior when the name is too long to be displayed? Ellipsis + hover text?

olivierlambert avatar Sep 13 '22 13:09 olivierlambert

Nice! What's the behavior when the name is too long to be displayed? Ellipsis + hover text?

ATM, the component UsageBar displays the text on several lines if he is too long. We can fix this in another PR.

MathieuRA avatar Sep 13 '22 14:09 MathieuRA

No worries, I was just curious :)

olivierlambert avatar Sep 13 '22 14:09 olivierlambert

@MathieuRA Could you rebase?

ByScripts avatar Oct 03 '22 09:10 ByScripts

UI misses some margins also compared to Figma:

ram usage@2x

ByScripts avatar Oct 04 '22 07:10 ByScripts

UI misses some margins also compared to Figma:

ram usage@2x

This will be fixed in another PR.

MathieuRA avatar Oct 04 '22 08:10 MathieuRA

When I shutdown a VM that is in the top 5, it doesn't disappear from the list. Can you reproduce?

pdonias avatar Oct 10 '22 08:10 pdonias