xen-orchestra icon indicating copy to clipboard operation
xen-orchestra copied to clipboard

WiP: feat(xo-server/delta backup): handle VDI migration

Open julien-f opened this issue 5 years ago • 6 comments

Fixes #2896

Store its UUID in metadata to avoid a delta afteter a migration.

Check list

Check items when done or if not relevant

  • [x] PR reference the relevant issue (e.g. Fixes #007)
  • [x] if UI changes, a screenshot has been added to the PR (none)
  • [ ] CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • [x] documentation updated (irrelevant)
  • [ ] I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

julien-f avatar May 29 '19 15:05 julien-f

It does not work, it appears XAPI empty other_config when migrating the VDI…

Requires more testing.

julien-f avatar May 29 '19 15:05 julien-f

@olivierlambert Do you want to do something about this in XCP-ng?

julien-f avatar Mar 25 '20 13:03 julien-f

Not sure to understand. I'm currently in a meeting. Ask @stormi

olivierlambert avatar Mar 25 '20 13:03 olivierlambert

Do you mean modifying the XAPI?

stormi avatar Mar 25 '20 13:03 stormi

@stormi yes.

We are trying to save the original UUID of a VDI in it's other_config property to avoid having to fall back to a full copy when it changed (in case of SR migration for instance).

Unfortunately, it appears (more tests required) that other_config is emptied when the VDI is migrating, defeating the purpose.

julien-f avatar Mar 25 '20 13:03 julien-f

So we should test if there's a field that's preserved after a VDI migration.

olivierlambert avatar Mar 25 '20 13:03 olivierlambert