rubiks-cube icon indicating copy to clipboard operation
rubiks-cube copied to clipboard

Styled tables in CSS

Open 96RadhikaJadhav opened this issue 3 years ago • 8 comments

This PR will resolve issue #5 .

96RadhikaJadhav avatar Mar 25 '21 18:03 96RadhikaJadhav

@vasu-gondaliya I have styled both tables on the page, so it will look the same. Could you please review it?

96RadhikaJadhav avatar Mar 25 '21 18:03 96RadhikaJadhav

@96RadhikaJadhav the tables look good. But I think it will look better if the colour scheme is dark based as the background is of that type too. What do you think?

vasu-gondaliya avatar Mar 26 '21 04:03 vasu-gondaliya

@96RadhikaJadhav the tables look good. But I think it will look better if the colour scheme is dark based as the background is of that type too. What do you think?

@vasu-gondaliya If we make it dark it will look like no changes have been done. But if you feel it will look good in dark then I can make the changes.

96RadhikaJadhav avatar Mar 27 '21 15:03 96RadhikaJadhav

Screenshot_20210327-211652.jpg Screenshot_20210327-211605.jpg @96RadhikaJadhav Something like this would look good. Or else you suggest some other style.

vasu-gondaliya avatar Mar 27 '21 16:03 vasu-gondaliya

image

See if this is looking good to you. Please let me know if you want it to change.

96RadhikaJadhav avatar Mar 27 '21 20:03 96RadhikaJadhav

@96RadhikaJadhav Try the coloured one, I think it would look good. And first update the fork as many changes have been made.

vasu-gondaliya avatar Mar 28 '21 02:03 vasu-gondaliya

@vasu-gondaliya I made the changes. Can you please check now?

96RadhikaJadhav avatar Mar 28 '21 14:03 96RadhikaJadhav

I saw the added css but I am not able to see the coloured rows. I think you need to remove the background color properties of "td" elements. And can you use more vibrant colours? Check it out here https://www.schemecolor.com/tag/rainbow?trend . And remove the thick border.

vasu-gondaliya avatar Mar 28 '21 16:03 vasu-gondaliya