pymca icon indicating copy to clipboard operation
pymca copied to clipboard

[WIP] multidetector xrf fits

Open woutdenolf opened this issue 4 years ago • 4 comments

woutdenolf avatar Aug 11 '20 12:08 woutdenolf

I think it would be much less intrusive to do the following:

  • ClassMcaTheory.py becomes LegacyClassMcaTheory
  • The new ClassMcaTheory imports McaTheory from LegacyClassMcaTheory
  • The new Class (if any) in ClassMcaTheory is named ClassMcaTheory as it is the style followed everywhere else in the project.

vasole avatar Jan 21 '21 16:01 vasole

ClassMcaTheory.py becomes LegacyClassMcaTheory.py

That's already the case.

The new Class (if any) in ClassMcaTheory is named ClassMcaTheory

Yes that will be the case.

The new ClassMcaTheory imports McaTheory from LegacyClassMcaTheory

That's not going to be possible imo.

woutdenolf avatar Jan 21 '21 16:01 woutdenolf

You are correct. At a certain point I put a dummy ClassMcaTheory to follow the convention available everywhere else :(

vasole avatar Jan 21 '21 16:01 vasole

We'll have to take care.

There are recipes around showing how to directly use the current McaTheory "public" API (configure, setData, estimate, startfit)

vasole avatar Jan 21 '21 16:01 vasole