Vasil Dimov

Broadcast own transactions only via short-lived Tor or I2P connections

168

_Parts of this PR are isolated in independent smaller PRs to ease review:_ * [x] _https://github.com/bitcoin/bitcoin/pull/29420_ * [x] _https://github.com/bitcoin/bitcoin/pull/33454_ * [ ] _https://github.com/bitcoin/bitcoin/pull/33565_ * [x] _https://github.com/bitcoin/bitcoin/pull/33567_ * [ ] _https://github.com/bitcoin/bitcoin/pull/33792_...

log: deduplicate category names and improve logging.cpp

1

The code in `logging.cpp` needs to: * Get the category name given the flag (e.g. `BCLog::PRUNE` -> `"prune"`) * Get the flag given the category name (e.g. `"prune"` -> `BCLog::PRUNE`)...

test: extend the SOCKS5 Python proxy to actually connect to a destination

7

If requested, make the SOCKS5 Python proxy redirect connections to a set of given destinations. Actually act as a real proxy, connecting the client to a destination, except that the...

doc: suggest only necessary Qt packages for installation on FreeBSD

4

The previously suggested `qt5` package is a meta package that does not install anything itself but depends on a bunch of others and is used as a convenience to install...

Make clang-tidy happy

6

* [x] Get https://include-what-you-use.org/ happy with this project `clang-tidy` supersedes this * [x] Integrate it either into `make test` or its own `make iwyu` `clang-tidy` is executed when compiling *...

net: log connections failures via SOCKS5 with less severity

2

It is expected to have some Bitcoin nodes unreachable some of the time. A failure to connect to an IPv4 or IPv6 node is already properly logged under category=net/severity=debug. Do...

util: avoid using thread_local variable that has a destructor

9

Store the thread name in a `thread_local` variable of type `char[]` instead of `std::string`. This avoids calling the destructor when the thread exits. This is a workaround for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278701 For...

Logging cleanup

6

* Move special cases from `LOG_CATEGORIES_BY_STR` to `GetLogCategory()` (suggested [here](https://github.com/bitcoin/bitcoin/pull/29419#discussion_r1547990373)). * Remove `"none"` and `"0"` from RPC `logging` help because that help text was wrong. `"none"` resulted in an error...

Avoid vector out of bounds access in ParserExposedBuffer.cpp

1

Accessing elements past the size of a `std::vector` is undefined behavior [1] and is actually checked in recent versions of LLVM libcxx, which is used in FreeBSD [2]. [1] https://en.cppreference.com/w/cpp/container/vector/operator_at:...

fuzz: FuzzedSock::Recv() don't lose bytes from MSG_PEEK read

4

Problem: If `FuzzedSock::Recv(N, MSG_PEEK)` is called then `N` bytes would be retrieved from the fuzz provider, saved in `m_peek_data` and returned to the caller (ok). If after this `FuzzedSock::Recv(M, 0)`...