Vamshi Maskuri

Results 466 comments of Vamshi Maskuri

@jdegoes I think it's ready for your final review

> @varshith257 This does not really fix the problem. It reorganizes the diff rendering code, but does not unify it between smart assertions and ordinary assertions. Do I need to...

> > @varshith257 This does not really fix the problem. It reorganizes the diff rendering code, but does not unify it between smart assertions and ordinary assertions. > @jdegoes Do...

@ghostdogpr This PR aims to unify rendering logic to SmartAssertions and ordinary assertions to ensure code reusability. But when the `renderdiff ` is applied to ordinary assertions equalTo function, CI...

> @ghostdogpr This PR aims to unify rendering logic to SmartAssertions and ordinary assertions to ensure code reusability. But when the `renderdiff ` is applied to ordinary assertions equalTo function,...

> @ghostdogpr This PR aims to unify rendering logic to SmartAssertions and ordinary assertions to ensure code reusability. But when the `renderdiff ` is applied to ordinary assertions equalTo function,...

> It doesn't compile because Diff[A] can only compare 2 values of type A but here we are comparing A and B which are different types. The existing code is...

> Maybe we can change `equalTo` to return an `Assertion[A]`, that way you can use `Diff[A]`. I wonder if there are cases where type inference won't work when B is...

@ghostdogpr The changes made to ordinary assertion to unify the same renderdiff of smartAssertions led to fail large chunks of test.

@jdegoes @ghostdogpr It's making it hard to use the same render diff logic to both smartAssertions and ordinaryAssertions as they behave differently with their input args. You'll be able to...